perf(uv): deduplicate wheel installs#1352
Conversation
tamird
left a comment
There was a problem hiding this comment.
This contains the full lazy-metadata change and currently repeats its causal CI failures. There is also an integration hole with the approved exclude_glob API: wheel variants receive the filter, but an sdist fallback selected through the public repository does not. Please extract/rebase after #1348, preserve the filter for both install paths, and add a real two-lock dedupe plus sdist-filter regression.
| "metadata_directory": install_cfg.metadata_directory, | ||
| "name": install_id, | ||
| "sbuild": install_cfg.sbuild, | ||
| "variant_installs": json.encode(variant_installs), |
There was a problem hiding this comment.
exclude_glob is forwarded to each concrete wheel variant above, but it is absent from this public-selector install_kwargs. If resolution falls back to an sdist, the selected install silently keeps files the caller explicitly excluded. Please forward the filter here too and exercise an actual sdist fallback; the current key tests fabricate exclude_glob and do not prove the selected install is filtered.
Depends on #1348.
Summary
Validation