Set size for cached client secrets in DefaultAppleClientSecretGenerator#1191
Open
yasmoradi wants to merge 2 commits into
Open
Set size for cached client secrets in DefaultAppleClientSecretGenerator#1191yasmoradi wants to merge 2 commits into
yasmoradi wants to merge 2 commits into
Conversation
…nerator Specifying a size is required when IMemoryCache is configured with a SizeLimit (aspnet-contrib#1190)
yasmoradi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the
MemoryCacheentry created for the Apple client secret has a definedSize.Motivation
When a developer configures
IMemoryCachewith aSizeLimit(e.g.,services.AddMemoryCache(options => options.SizeLimit = 1024)), all cache entries must have aSizespecified. Currently,DefaultAppleClientSecretGeneratordoes not set this value, which causes the cache to throw an exception.By setting
entry.Size = 1, we ensure compatibility with memory-constrained configurations and prevent potential GC pressure or performance degradation.Related Issue
Fixes #1190