Skip to content

Commit 7eb03b8

Browse files
authored
docs: remove stale nameOrHandle param from switchToWindow JSDoc (#5)
* docs: remove stale nameOrHandle param from switchToWindow JSDoc * fix: replace Replace InstanceType<typeof DappDriver.Instance.Extension.pages.X> with IConfirmation
1 parent dbf7fc8 commit 7eb03b8

File tree

9 files changed

+9
-18
lines changed

9 files changed

+9
-18
lines changed

src/wallet/pages/add-network.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver';
1212
export class AddNetwork implements IConfirmation {
1313
public url: string | RegExp;
1414
public title: string;
15-
private readonly addNetwork: InstanceType<typeof DappDriver.Instance.Extension.pages.AddNetwork>;
15+
private readonly addNetwork: IConfirmation;
1616

1717
constructor() {
1818
this.addNetwork = new DappDriver.Instance.Extension.pages.AddNetwork();
@@ -58,7 +58,6 @@ export class AddNetwork implements IConfirmation {
5858
*
5959
*
6060
* @template TPage
61-
* @param {*} nameOrHandle
6261
* @param {new () => TPage} page
6362
* @return {*} {Promise<TPage>}
6463
* @memberof AddNetwork

src/wallet/pages/approve-all.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver';
1212
export class ApproveAll implements IConfirmation {
1313
public url: string | RegExp;
1414
public title: string;
15-
private readonly approveAll: InstanceType<typeof DappDriver.Instance.Extension.pages.ApproveAll>;
15+
private readonly approveAll: IConfirmation;
1616

1717
constructor() {
1818
this.approveAll = new DappDriver.Instance.Extension.pages.ApproveAll();
@@ -57,7 +57,6 @@ export class ApproveAll implements IConfirmation {
5757
*
5858
*
5959
* @template TPage
60-
* @param {*} nameOrHandle
6160
* @param {new () => TPage} page
6261
* @return {*} {Promise<TPage>}
6362
* @memberof ApproveAll

src/wallet/pages/approve.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { DappDriver } from '../../session/dapp-driver';
55
export class Approve implements IConfirmation {
66
public url: string | RegExp;
77
public title: string;
8-
private readonly approve: InstanceType<typeof DappDriver.Instance.Extension.pages.Approve>;
8+
private readonly approve: IConfirmation;
99

1010
constructor() {
1111
this.approve = new DappDriver.Instance.Extension.pages.Approve();
@@ -51,7 +51,6 @@ export class Approve implements IConfirmation {
5151
*
5252
*
5353
* @template TPage
54-
* @param {*} nameOrHandle
5554
* @param {new () => TPage} page
5655
* @return {*} {Promise<TPage>}
5756
* @memberof Approve

src/wallet/pages/confirm-transaction.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver';
1212
export class ConfirmTransaction implements IConfirmation {
1313
public url: string | RegExp;
1414
public title: string;
15-
private readonly confirmTx: InstanceType<typeof DappDriver.Instance.Extension.pages.ConfirmTransaction>;
15+
private readonly confirmTx: IConfirmation;
1616

1717
constructor() {
1818
this.confirmTx = new DappDriver.Instance.Extension.pages.ConfirmTransaction();
@@ -58,7 +58,6 @@ export class ConfirmTransaction implements IConfirmation {
5858
*
5959
*
6060
* @template TPage
61-
* @param {*} nameOrHandle
6261
* @param {new () => TPage} page
6362
* @return {*} {Promise<TPage>}
6463
* @memberof ConfirmTransaction

src/wallet/pages/connect.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver';
1212
export class Connect implements IConfirmation {
1313
public url: string | RegExp;
1414
public title: string;
15-
private readonly connect: InstanceType<typeof DappDriver.Instance.Extension.pages.Connect>;
15+
private readonly connect: IConfirmation;
1616

1717
constructor() {
1818
this.connect = new DappDriver.Instance.Extension.pages.Connect();
@@ -58,7 +58,6 @@ export class Connect implements IConfirmation {
5858
*
5959
*
6060
* @template TPage
61-
* @param {*} nameOrHandle
6261
* @param {new () => TPage} page
6362
* @return {*} {Promise<TPage>}
6463
* @memberof Connect

src/wallet/pages/send.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver';
1212
export class Send implements IConfirmation {
1313
public url: string | RegExp;
1414
public title: string;
15-
private readonly send: InstanceType<typeof DappDriver.Instance.Extension.pages.Send>;
15+
private readonly send: IConfirmation;
1616

1717
constructor() {
1818
this.send = new DappDriver.Instance.Extension.pages.Send();
@@ -58,7 +58,6 @@ export class Send implements IConfirmation {
5858
*
5959
*
6060
* @template TPage
61-
* @param {*} nameOrHandle
6261
* @param {new () => TPage} page
6362
* @return {*} {Promise<TPage>}
6463
* @memberof Send

src/wallet/pages/sign-in-request.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver';
1212
export class SignInRequest implements IConfirmation {
1313
public url: string | RegExp;
1414
public title: string;
15-
private readonly signInRequest: InstanceType<typeof DappDriver.Instance.Extension.pages.SignInRequest>;
15+
private readonly signInRequest: IConfirmation;
1616

1717
constructor() {
1818
this.signInRequest = new DappDriver.Instance.Extension.pages.SignInRequest();
@@ -58,7 +58,6 @@ export class SignInRequest implements IConfirmation {
5858
*
5959
*
6060
* @template TPage
61-
* @param {*} nameOrHandle
6261
* @param {new () => TPage} page
6362
* @return {*} {Promise<TPage>}
6463
* @memberof SignInRequest

src/wallet/pages/sign-message.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver';
1212
export class SignMessage implements IConfirmation {
1313
public url: string | RegExp;
1414
public title: string;
15-
private readonly signMessage: InstanceType<typeof DappDriver.Instance.Extension.pages.SignMessage>;
15+
private readonly signMessage: IConfirmation;
1616

1717
constructor() {
1818
this.signMessage = new DappDriver.Instance.Extension.pages.SignMessage();
@@ -58,7 +58,6 @@ export class SignMessage implements IConfirmation {
5858
*
5959
*
6060
* @template TPage
61-
* @param {*} nameOrHandle
6261
* @param {new () => TPage} page
6362
* @return {*} {Promise<TPage>}
6463
* @memberof SignMessage

src/wallet/pages/signature-request.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { DappDriver } from '../../session/dapp-driver';
1212
export class SignatureRequest implements IConfirmation {
1313
public url: string | RegExp;
1414
public title: string;
15-
private readonly signatureRequest: InstanceType<typeof DappDriver.Instance.Extension.pages.SignatureRequest>;
15+
private readonly signatureRequest: IConfirmation;
1616

1717
constructor() {
1818
this.signatureRequest = new DappDriver.Instance.Extension.pages.SignatureRequest();
@@ -57,7 +57,6 @@ export class SignatureRequest implements IConfirmation {
5757
*
5858
*
5959
* @template TPage
60-
* @param {*} nameOrHandle
6160
* @param {new () => TPage} page
6261
* @return {*} {Promise<TPage>}
6362
* @memberof SignatureRequest

0 commit comments

Comments
 (0)