style: Make clippy happy

Author: epage

examples/example_fixture.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::exit)]
+#![allow(clippy::exit, reason = "binary needs use of exit")]
 
 use std::env;
 use std::error::Error;

examples/failure.rs

@@ -1,4 +1,4 @@
-#[allow(clippy::wildcard_imports)] // false positive
+#[allow(clippy::wildcard_imports, reason = "false positive")]
 use assert_cmd::prelude::*;
 
 use std::process::Command;

src/assert.rs

@@ -571,7 +571,7 @@ pub struct EqCodePredicate(predicates::ord::EqPredicate<i32>);
 impl EqCodePredicate {
     pub(crate) fn new(value: i32) -> Self {
         let pred = predicates::ord::eq(value);
-        EqCodePredicate(pred)
+        Self(pred)
     }
 }
 
@@ -640,7 +640,7 @@ pub struct InCodePredicate(predicates::iter::InPredicate<i32>);
 impl InCodePredicate {
     pub(crate) fn new<I: IntoIterator<Item = i32>>(value: I) -> Self {
         let pred = predicates::iter::in_iter(value);
-        InCodePredicate(pred)
+        Self(pred)
     }
 }
 
@@ -765,11 +765,11 @@ pub struct BytesContentOutputPredicate(Cow<'static, [u8]>);
 
 impl BytesContentOutputPredicate {
     pub(crate) fn new(value: &'static [u8]) -> Self {
-        BytesContentOutputPredicate(Cow::from(value))
+        Self(Cow::from(value))
     }
 
     pub(crate) fn from_vec(value: Vec<u8>) -> Self {
-        BytesContentOutputPredicate(Cow::from(value))
+        Self(Cow::from(value))
     }
 }
 
@@ -843,12 +843,12 @@ pub struct StrContentOutputPredicate(
 impl StrContentOutputPredicate {
     pub(crate) fn from_str(value: &'static str) -> Self {
         let pred = predicates::str::diff(value).from_utf8();
-        StrContentOutputPredicate(pred)
+        Self(pred)
     }
 
     pub(crate) fn from_string(value: String) -> Self {
         let pred = predicates::str::diff(value).from_utf8();
-        StrContentOutputPredicate(pred)
+        Self(pred)
     }
 }
 
@@ -933,7 +933,7 @@ where
 {
     pub(crate) fn new(pred: P) -> Self {
         let pred = pred.from_utf8();
-        StrOutputPredicate(pred)
+        Self(pred)
     }
 }
 

src/bin/bin_fixture.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::exit)]
+#![allow(clippy::exit, reason = "binary needs use of exit")]
 
 use std::env;
 use std::error::Error;

src/cargo.rs

@@ -142,7 +142,7 @@ where
 
 impl CommandCargoExt for crate::cmd::Command {
     fn cargo_bin<S: AsRef<str>>(name: S) -> Result<Self, CargoError> {
-        crate::cmd::Command::cargo_bin(name)
+        Self::cargo_bin(name)
     }
 }
 

src/cmd.rs

@@ -455,7 +455,7 @@ impl Command {
         input: Option<Vec<u8>>,
         timeout: Option<std::time::Duration>,
     ) -> io::Result<process::Output> {
-        #![allow(clippy::unwrap_used)] // changes behavior in some tests
+        #![allow(clippy::unwrap_used, reason = "changes behavior in some tests")]
 
         fn read<R>(mut input: R) -> std::thread::JoinHandle<io::Result<Vec<u8>>>
         where
@@ -611,7 +611,7 @@ impl Command {
 
 impl From<process::Command> for Command {
     fn from(cmd: process::Command) -> Self {
-        Command::from_std(cmd)
+        Self::from_std(cmd)
     }
 }
 

src/output.rs

@@ -266,8 +266,8 @@ enum OutputCause {
 impl fmt::Display for OutputCause {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match *self {
-            OutputCause::Expected(ref e) => write!(f, "{e:#}"),
-            OutputCause::Unexpected(ref e) => write!(f, "{e:#}"),
+            Self::Expected(ref e) => write!(f, "{e:#}"),
+            Self::Unexpected(ref e) => write!(f, "{e:#}"),
         }
     }
 }
@@ -331,7 +331,7 @@ pub(crate) struct DebugBuffer {
 
 impl DebugBuffer {
     pub(crate) fn new(buffer: Vec<u8>) -> Self {
-        DebugBuffer {
+        Self {
             buffer: buffer.into(),
         }
     }
@@ -344,7 +344,10 @@ impl fmt::Display for DebugBuffer {
 }
 
 fn format_bytes(data: &[u8], f: &mut impl fmt::Write) -> fmt::Result {
-    #![allow(clippy::assertions_on_constants)]
+    #![allow(
+        clippy::assertions_on_constants,
+        reason = "enforce constant relationships on edit"
+    )]
 
     const LINES_MIN_OVERFLOW: usize = 80;
     const LINES_MAX_START: usize = 20;