fix!: Remove unstable --format=junit

Author: epage

crates/libtest-lexarg/src/lib.rs

@@ -78,8 +78,6 @@ pub enum OutputFormat {
     Terse,
     /// JSON output
     Json,
-    /// JUnit output
-    Junit,
 }
 
 impl Default for OutputFormat {
@@ -123,12 +121,11 @@ Options:
                         on serially (default);
                         always = always colorize output;
                         never = never colorize output;
-        --format pretty|terse|json|junit
+        --format pretty|terse|json
                         Configure formatting of output:
                         pretty = Print verbose output;
                         terse = Display one character per test;
                         json = Output a json document;
-                        junit = Output a JUnit document
         --show-output   Show captured stdout of successful tests
     -Z unstable-options Enable nightly-only flags:
                         unstable-options = Allow use of experimental features
@@ -268,13 +265,12 @@ impl TestOptsBuilder {
                 let format = parser
                     .next_flag_value()
                     .ok_or_missing(Value(std::ffi::OsStr::new("FORMAT")))
-                    .one_of(&["pretty", "terse", "json", "junit"])
+                    .one_of(&["pretty", "terse", "json"])
                     .within(arg)?;
                 self.format = Some(match format {
                     "pretty" => OutputFormat::Pretty,
                     "terse" => OutputFormat::Terse,
                     "json" => OutputFormat::Json,
-                    "junit" => OutputFormat::Junit,
                     _ => unreachable!("`one_of` should prevent this"),
                 });
             }

crates/libtest2-harness/Cargo.toml

@@ -27,7 +27,6 @@ pre-release-replacements = [
 default = []
 color = ["dep:anstream", "dep:anstyle"]
 json = ["libtest-json/serde", "dep:serde", "dep:serde_json"]
-junit = []
 threads = []
 
 [dependencies]

crates/libtest2-harness/src/harness.rs

@@ -149,15 +149,6 @@ fn notifier(opts: &libtest_lexarg::TestOpts) -> std::io::Result<Box<dyn notify::
         _ if opts.list => Box::new(notify::TerseListNotifier::new(stdout)),
         OutputFormat::Pretty => Box::new(notify::PrettyRunNotifier::new(stdout)),
         OutputFormat::Terse => Box::new(notify::TerseRunNotifier::new(stdout)),
-        #[cfg(feature = "junit")]
-        OutputFormat::Junit => Box::new(notify::JunitRunNotifier::new(stdout)),
-        #[cfg(not(feature = "junit"))]
-        OutputFormat::Junit => {
-            return Err(std::io::Error::new(
-                std::io::ErrorKind::Other,
-                "`--format=junit` is not supported",
-            ));
-        }
     };
     Ok(notifier)
 }

crates/libtest2-harness/src/notify/junit.rs

@@ -1,7 +1,5 @@
 #[cfg(feature = "json")]
 mod json;
-#[cfg(feature = "junit")]
-mod junit;
 #[cfg(not(feature = "color"))]
 mod no_style;
 mod pretty;
@@ -12,8 +10,6 @@ mod terse;
 
 #[cfg(feature = "json")]
 pub(crate) use json::*;
-#[cfg(feature = "junit")]
-pub(crate) use junit::*;
 #[cfg(not(feature = "color"))]
 pub(crate) use no_style::*;
 pub(crate) use pretty::*;

crates/libtest2-harness/src/notify/mod.rs

@@ -24,10 +24,9 @@ pre-release-replacements = [
 ]
 
 [features]
-default = ["color", "json", "junit", "threads"]
+default = ["color", "json", "threads"]
 color = ["libtest2-harness/color"]
 json = ["libtest2-harness/json"]
-junit = ["libtest2-harness/junit"]
 threads = ["libtest2-harness/threads"]
 
 [dependencies]

crates/libtest2-mimic/Cargo.toml

@@ -688,54 +688,6 @@ fn test_json() {
     );
 }
 
-#[test]
-#[cfg(feature = "junit")]
-fn list_junit() {
-    check(
-        &["-Zunstable-options", "--format=junit", "--list", "a"],
-        0,
-        r#"bear: test
-cat: test
-
-2 tests
-
-"#,
-        r#"bear: test
-cat: test
-
-2 tests
-
-"#,
-    );
-}
-
-#[test]
-#[cfg(feature = "junit")]
-fn test_junit() {
-    check(
-        &["-Zunstable-options", "--format=junit", "a"],
-        0,
-        r#"<?xml version="1.0" encoding="UTF-8"?>
-<testsuites>
-<testsuite name="test" package="test" id="0" tests="2" errors="0" failures="0" skipped="1" >
-<testcase classname="crate" name="cat" time="0.000s"/>
-<system-out/>
-<system-err/>
-</testsuite>
-</testsuites>
-"#,
-        r#"<?xml version="1.0" encoding="UTF-8"?>
-<testsuites>
-<testsuite name="test" package="test" id="0" tests="2" errors="0" failures="0" skipped="1" >
-<testcase classname="crate" name="cat" time="0.000s"/>
-<system-out/>
-<system-err/>
-</testsuite>
-</testsuites>
-"#,
-    );
-}
-
 #[test]
 fn terse_output() {
     check(

crates/libtest2-mimic/tests/testsuite/mixed_bag.rs

@@ -24,10 +24,9 @@ pre-release-replacements = [
 ]
 
 [features]
-default = ["color", "json", "junit", "threads"]
+default = ["color", "json", "threads"]
 color = ["libtest2-harness/color"]
 json = ["libtest2-harness/json"]
-junit = ["libtest2-harness/junit"]
 threads = ["libtest2-harness/threads"]
 
 [dependencies]

crates/libtest2/Cargo.toml

@@ -695,54 +695,6 @@ fn test_json() {
     );
 }
 
-#[test]
-#[cfg(feature = "junit")]
-fn list_junit() {
-    check(
-        &["-Zunstable-options", "--format=junit", "--list", "a"],
-        0,
-        r#"bear: test
-cat: test
-
-2 tests
-
-"#,
-        r#"bear: test
-cat: test
-
-2 tests
-
-"#,
-    );
-}
-
-#[test]
-#[cfg(feature = "junit")]
-fn test_junit() {
-    check(
-        &["-Zunstable-options", "--format=junit", "a"],
-        0,
-        r#"<?xml version="1.0" encoding="UTF-8"?>
-<testsuites>
-<testsuite name="test" package="test" id="0" tests="2" errors="0" failures="0" skipped="1" >
-<testcase classname="crate" name="cat" time="0.000s"/>
-<system-out/>
-<system-err/>
-</testsuite>
-</testsuites>
-"#,
-        r#"<?xml version="1.0" encoding="UTF-8"?>
-<testsuites>
-<testsuite name="test" package="test" id="0" tests="2" errors="0" failures="0" skipped="1" >
-<testcase classname="crate" name="cat" time="0.000s"/>
-<system-out/>
-<system-err/>
-</testsuite>
-</testsuites>
-"#,
-    );
-}
-
 #[test]
 fn terse_output() {
     check(