fix(json)!: Make schema snake_case

This better reflects rustc's json messages

Author: epage

crates/libtest-json/event.schema.json

@@ -7,7 +7,7 @@
       "properties": {
         "event": {
           "type": "string",
-          "const": "discover-start"
+          "const": "discover_start"
         }
       },
       "required": [
@@ -29,7 +29,7 @@
         },
         "event": {
           "type": "string",
-          "const": "discover-case"
+          "const": "discover_case"
         }
       },
       "required": [
@@ -52,7 +52,7 @@
         },
         "event": {
           "type": "string",
-          "const": "discover-complete"
+          "const": "discover_complete"
         }
       },
       "required": [
@@ -64,7 +64,7 @@
       "properties": {
         "event": {
           "type": "string",
-          "const": "suite-start"
+          "const": "suite_start"
         }
       },
       "required": [
@@ -79,7 +79,7 @@
         },
         "event": {
           "type": "string",
-          "const": "case-start"
+          "const": "case_start"
         }
       },
       "required": [
@@ -125,7 +125,7 @@
         },
         "event": {
           "type": "string",
-          "const": "case-complete"
+          "const": "case_complete"
         }
       },
       "required": [
@@ -148,7 +148,7 @@
         },
         "event": {
           "type": "string",
-          "const": "suite-complete"
+          "const": "suite_complete"
         }
       },
       "required": [

crates/libtest-json/src/event.rs

@@ -1,7 +1,7 @@
 #[derive(Clone, Debug)]
 #[cfg_attr(feature = "unstable-schema", derive(schemars::JsonSchema))]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
-#[cfg_attr(feature = "serde", serde(rename_all = "kebab-case"))]
+#[cfg_attr(feature = "serde", serde(rename_all = "snake_case"))]
 #[cfg_attr(feature = "serde", serde(tag = "event"))]
 pub enum Event {
     DiscoverStart,
@@ -81,7 +81,7 @@ fn is_true(yes: &bool) -> bool {
 #[derive(Copy, Clone, Default, Debug, PartialEq, Eq)]
 #[cfg_attr(feature = "unstable-schema", derive(schemars::JsonSchema))]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
-#[cfg_attr(feature = "serde", serde(rename_all = "kebab-case"))]
+#[cfg_attr(feature = "serde", serde(rename_all = "snake_case"))]
 pub enum RunMode {
     #[default]
     Test,
@@ -104,7 +104,7 @@ impl RunMode {
 #[derive(Copy, Clone, Debug, PartialEq, Eq)]
 #[cfg_attr(feature = "unstable-schema", derive(schemars::JsonSchema))]
 #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
-#[cfg_attr(feature = "serde", serde(rename_all = "kebab-case"))]
+#[cfg_attr(feature = "serde", serde(rename_all = "snake_case"))]
 pub enum RunStatus {
     Ignored,
     Failed,

crates/libtest-json/tests/roundtrip.rs

@@ -18,7 +18,7 @@ fn t(input: libtest_json::Event, snapshot: impl IntoData) {
 fn discover_start() {
     t(
         libtest_json::Event::DiscoverStart,
-        str![[r#"{"event":"discover-start"}"#]],
+        str![[r#"{"event":"discover_start"}"#]],
     );
 }
 
@@ -30,7 +30,7 @@ fn discover_case() {
             mode: libtest_json::RunMode::Test,
             run: true,
         },
-        str![[r#"{"event":"discover-case","name":"Hello\tworld!"}"#]],
+        str![[r#"{"event":"discover_case","name":"Hello\tworld!"}"#]],
     );
 
     t(
@@ -39,30 +39,30 @@ fn discover_case() {
             mode: libtest_json::RunMode::Bench,
             run: false,
         },
-        str![[r#"{"event":"discover-case","name":"Hello\tworld!","mode":"bench","run":false}"#]],
+        str![[r#"{"event":"discover_case","name":"Hello\tworld!","mode":"bench","run":false}"#]],
     );
 }
 
 #[test]
 fn discover_complete() {
     t(
         libtest_json::Event::DiscoverComplete { elapsed_s: None },
-        str![[r#"{"event":"discover-complete"}"#]],
+        str![[r#"{"event":"discover_complete"}"#]],
     );
 
     t(
         libtest_json::Event::DiscoverComplete {
             elapsed_s: Some(libtest_json::Elapsed(Default::default())),
         },
-        str![[r#"{"event":"discover-complete","elapsed_s":"0"}"#]],
+        str![[r#"{"event":"discover_complete","elapsed_s":"0"}"#]],
     );
 }
 
 #[test]
 fn suite_start() {
     t(
         libtest_json::Event::SuiteStart,
-        str![[r#"{"event":"suite-start"}"#]],
+        str![[r#"{"event":"suite_start"}"#]],
     );
 }
 
@@ -72,7 +72,7 @@ fn case_start() {
         libtest_json::Event::CaseStart {
             name: "Hello\tworld!".to_owned(),
         },
-        str![[r#"{"event":"case-start","name":"Hello\tworld!"}"#]],
+        str![[r#"{"event":"case_start","name":"Hello\tworld!"}"#]],
     );
 }
 
@@ -86,7 +86,7 @@ fn case_complete() {
             message: None,
             elapsed_s: None,
         },
-        str![[r#"{"event":"case-complete","name":"Hello\tworld!"}"#]],
+        str![[r#"{"event":"case_complete","name":"Hello\tworld!"}"#]],
     );
 
     t(
@@ -98,7 +98,7 @@ fn case_complete() {
             elapsed_s: Some(libtest_json::Elapsed(Default::default())),
         },
         str![[
-            r#"{"event":"case-complete","name":"Hello\tworld!","mode":"bench","status":"ignored","message":"This\tfailed","elapsed_s":"0"}"#
+            r#"{"event":"case_complete","name":"Hello\tworld!","mode":"bench","status":"ignored","message":"This\tfailed","elapsed_s":"0"}"#
         ]],
     );
 }
@@ -107,13 +107,13 @@ fn case_complete() {
 fn suite_complete() {
     t(
         libtest_json::Event::SuiteComplete { elapsed_s: None },
-        str![[r#"{"event":"suite-complete"}"#]],
+        str![[r#"{"event":"suite_complete"}"#]],
     );
 
     t(
         libtest_json::Event::SuiteComplete {
             elapsed_s: Some(libtest_json::Elapsed(Default::default())),
         },
-        str![[r#"{"event":"suite-complete","elapsed_s":"0"}"#]],
+        str![[r#"{"event":"suite_complete","elapsed_s":"0"}"#]],
     );
 }