fix!: Fix typo in TestContext::elapsed_s#134
Merged
epage merged 1 commit intoassert-rs:mainfrom Oct 16, 2025
Merged
Conversation
BREAKING CHANGE: Changes the name of a public method on the type `TestContext` from `elapased_s` to `elapsed_s`
epage
reviewed
Oct 16, 2025
Collaborator
|
Thanks! |
Collaborator
That is the unit of elapsed time (seconds) |
Pull Request Test Coverage Report for Build 18563963868Details
💛 - Coveralls |
Contributor
Author
That was my first guess, but then I was confused by it using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function seems to have been incorrectly named
elapased_s, which is not a word ofcourse. Just thought I'd fix it. The_ssuffix is still a bit confusing to me, but it seems to be used a lot of places in the codebase, so I assume this is intentional.