Skip to content

feat(lexarg): Decouple compatibility surface, allowing for helpers#82

Merged
epage merged 21 commits intoassert-rs:mainfrom
epage:split
Mar 27, 2025
Merged

feat(lexarg): Decouple compatibility surface, allowing for helpers#82
epage merged 21 commits intoassert-rs:mainfrom
epage:split

Conversation

@epage
Copy link
Copy Markdown
Collaborator

@epage epage commented Mar 27, 2025

By pulling out lexarg_parser, lexarg can have more helpers and more general policy. This also allowed reducing the API surface of lexarg_error.

This does come at the cost of more crates to compile and we're forcing more code on people but hopefully the compile time costs are not too great.

Comment thread crates/lexarg/src/lib.rs Fixed
Comment thread crates/lexarg/src/lib.rs Fixed
Comment thread crates/lexarg/src/lib.rs Fixed
Comment thread crates/libtest2-harness/src/harness.rs Fixed
Comment thread crates/libtest2-harness/src/harness.rs Fixed
Comment thread crates/libtest2-harness/src/harness.rs Fixed
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 27, 2025

Pull Request Test Coverage Report for Build 14113534492

Details

  • 128 of 284 (45.07%) changed or added relevant lines in 5 files are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.9%) to 28.397%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/lexarg-error/src/lib.rs 0 10 0.0%
crates/libtest2-harness/src/harness.rs 0 14 0.0%
crates/lexarg-parser/src/lib.rs 128 157 81.53%
crates/lexarg/src/lib.rs 0 47 0.0%
crates/libtest-lexarg/src/lib.rs 0 56 0.0%
Files with Coverage Reduction New Missed Lines %
crates/lexarg-error/src/lib.rs 3 0.0%
crates/libtest-lexarg/src/lib.rs 4 0.0%
crates/libtest2-harness/src/harness.rs 6 0.0%
Totals Coverage Status
Change from base Build 14110905723: -0.9%
Covered Lines: 326
Relevant Lines: 1148

💛 - Coveralls

@epage epage force-pushed the split branch 2 times, most recently from 39a6af0 to 1330cdf Compare March 27, 2025 18:00
@epage epage merged commit b892828 into assert-rs:main Mar 27, 2025
16 of 17 checks passed
@epage epage deleted the split branch March 27, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants