refactor: append Async suffix to async Task methods#713
Merged
Conversation
Renamed 14 async Task methods across Scrapper and OneDrive.Sync.Client to follow .NET naming conventions. Event handlers (async void) are explicitly excluded as per C# standards. Methods renamed: - Scrapper: SaveImage → SaveImageAsync, ProcessSearchCategories → ProcessSearchCategoriesAsync, ProcessAllCategoryPages → ProcessAllCategoryPagesAsync, GetImageFromPage → GetImageFromPageAsync, ProcessTheImageTags → ProcessTheImageTagsAsync, GetTags → GetTagsAsync, GetPageHeader (x2) → GetPageHeaderAsync, GetImagePageLinks (x3) → GetImagePageLinksAsync, Clear → ClearAsync - OneDrive.Sync.Client: GetUploadedDocumentId → GetUploadedDocumentIdAsync, RecordCompletion → RecordCompletionAsync Updated all call sites and interface declarations. Test method names remain unchanged; only internal call sites updated. - Build: clean + no-restore → zero errors, zero warnings - Tests: all 2329+ tests pass - No Avalonia bindings affected (no XAML references to these methods) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
astar-development-jb
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Append "Async" suffix to async Task/Task methods across Scrapper and OneDrive.Sync.Client apps. Follows .NET naming conventions.
Event handlers (async void) intentionally excluded per standard convention.
Methods Renamed (14 total)
Scrapper (12):
OneDrive.Sync.Client (2):
Test Coverage
All call sites updated (40+ references). Test method names unchanged per requirement. All 2329+ tests pass.
Build: clean ✓ | warnings: 0 | tests: all pass
🤖 Generated with Claude Code