Skip to content

Rename wallpaper Scrapper to Scraper#715

Merged
astar-development-jb merged 2 commits into
mainfrom
rename-scrapper-to-scraper
Jul 9, 2026
Merged

Rename wallpaper Scrapper to Scraper#715
astar-development-jb merged 2 commits into
mainfrom
rename-scrapper-to-scraper

Conversation

@jbarden

@jbarden jbarden commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Rename the wallpaper desktop app from Scrapper to Scraper across the solution, project folders, namespaces, identifiers, docs, and related references so the repo uses the corrected spelling consistently.

Type of change

  • Feature
  • Bug fix
  • Refactor
  • CI/CD
  • Documentation
  • Maintenance

Related issues / links

How was this tested?

  • Unit tests added/updated
  • Manual validation
  • Not applicable

Impacted areas

apps/desktop/Scraper, AStar.Dev.slnx, .vscode/launch.json, packages/AStar.Dev.Infrastructure.AppDb, docs/plans


TDD Checklist (required)

  • Builds locally
  • Tests pass (dotnet test)
  • No new analyzer warnings
  • Public API changes reviewed
  • Documentation updated (if applicable)
  • Not applicable

How to run tests locally

# Restore and run tests
dotnet restore AStar.Dev.slnx
dotnet test --verbosity normal

Notes for reviewers

  • The branch also includes a permissions update commit at the tip.
  • CI warnings unrelated to this rename still exist in some projects (for example NU1903 from SQLitePCLRaw.lib.e_sqlite3).

@jbarden jbarden requested a review from a team July 9, 2026 02:15
@astar-development-jb astar-development-jb enabled auto-merge (squash) July 9, 2026 02:16
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Test results

3 124 tests  ±0   3 123 ✅ ±0   1m 25s ⏱️ -4s
   13 suites ±0       1 💤 ±0 
   13 files   ±0       0 ❌ ±0 

Results for commit f06fa09. ± Comparison against base commit 063b6b4.

This pull request removes 400 and adds 400 tests. Note that renamed tests count towards both.
AStar.Dev.Wallpaper.Scrapper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_both_the_name_and_level_are_invalid_then_both_errors_are_accumulated
AStar.Dev.Wallpaper.Scrapper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_the_level_is_above_the_maximum_then_the_result_is_invalid
AStar.Dev.Wallpaper.Scrapper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_the_level_is_below_the_minimum_then_the_result_is_invalid
AStar.Dev.Wallpaper.Scrapper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_the_level_is_invalid_then_the_error_property_identifies_the_row_and_field
AStar.Dev.Wallpaper.Scrapper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_the_name_and_level_are_valid_then_the_result_is_valid
AStar.Dev.Wallpaper.Scrapper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_the_name_is_empty_then_the_error_property_identifies_the_row_and_field
AStar.Dev.Wallpaper.Scrapper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_the_name_is_empty_then_the_result_is_invalid
AStar.Dev.Wallpaper.Scrapper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_validating_all_rows_and_all_are_valid_then_the_result_is_valid
AStar.Dev.Wallpaper.Scrapper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_validating_all_rows_and_three_rows_are_invalid_then_all_three_errors_are_reported
AStar.Dev.Wallpaper.Scrapper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_validating_all_rows_and_three_rows_are_invalid_then_the_errors_are_reported_in_row_order
…
AStar.Dev.Wallpaper.Scraper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_both_the_name_and_level_are_invalid_then_both_errors_are_accumulated
AStar.Dev.Wallpaper.Scraper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_the_level_is_above_the_maximum_then_the_result_is_invalid
AStar.Dev.Wallpaper.Scraper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_the_level_is_below_the_minimum_then_the_result_is_invalid
AStar.Dev.Wallpaper.Scraper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_the_level_is_invalid_then_the_error_property_identifies_the_row_and_field
AStar.Dev.Wallpaper.Scraper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_the_name_and_level_are_valid_then_the_result_is_valid
AStar.Dev.Wallpaper.Scraper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_the_name_is_empty_then_the_error_property_identifies_the_row_and_field
AStar.Dev.Wallpaper.Scraper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_the_name_is_empty_then_the_result_is_invalid
AStar.Dev.Wallpaper.Scraper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_validating_all_rows_and_all_are_valid_then_the_result_is_valid
AStar.Dev.Wallpaper.Scraper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_validating_all_rows_and_three_rows_are_invalid_then_all_three_errors_are_reported
AStar.Dev.Wallpaper.Scraper.Tests.Unit.DTOs.GivenTheFileClassificationDtoValidator ‑ when_validating_all_rows_and_three_rows_are_invalid_then_the_errors_are_reported_in_row_order
…

@astar-development-jb astar-development-jb merged commit 4982890 into main Jul 9, 2026
7 checks passed
@astar-development-jb astar-development-jb deleted the rename-scrapper-to-scraper branch July 9, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants