Resolve mixin conflict between Krypton and e4mc#153
Open
XandarNull wants to merge 4 commits into
Open
Conversation
Added a check to disable ServerLoginNetworkHandlerMixin if e4mc is loaded to prevent conflicts with its encryption handling.
|
@astei hi! I've only noticed that there is a big conflict between two great minecraft mods. This request seems to resolve it, would you please consider adding it to the mod to enable players play seamlessly on thier favoirite modpacks? Thanks in advance! |
Updated mixin exclusion logic to disable ServerLoginNetworkHandlerMixin when e4mc is loaded, replacing it with ServerLoginPacketListenerImplMixin.
|
Hello @astei, can you merge this please into the newest release? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves mixin conflict between Krypton and e4mc by disabling ServerLoginNetworkHandlerMixin when e4mc is present. Both mods redirect the same method during encryption setup, causing conflicts.
Fixes #152