Unquote variables mistakenly quoted by PR awalsh128#177.

* The variable containing the list of packages was mistakenly double-quoted
in several places which caused the package lists to be treated as one long
single package name.

* The regex in get_install_script_filepath contained an errant pair of single
quotes which caused the test to always fail.

Author: gtjoseph

action.yml

@@ -17,7 +17,8 @@ inputs:
   execute_install_scripts:
     description: 'Execute Debian package pre and post install script upon restore. See README.md caveats for more information.'
     required: false
-    default: 'false'
+    type: boolean
+    default: false
   empty_packages_behavior:
     description: >
       Desired behavior when the provided package list is empty.
@@ -34,7 +35,8 @@ inputs:
   debug:
     description: 'Enable debugging when there are issues with action. Minor performance penalty.'
     required: false
-    default: 'false'
+    type: boolean
+    default: false
   add-repository:
     description: 'Space delimited list of repositories to add via apt-add-repository before installing packages. Supports PPA (ppa:user/repo) and other repository formats.'
     required: false

install_and_cache_pkgs.sh

@@ -74,7 +74,11 @@ log "Clean installing ${package_count} packages..."
 # Note: sudo doesn't affect redirects, but we want the output in the file anyway
 # shellcheck disable=SC2024
 # We intentionally redirect output here; the redirect happens as the current user which is fine
-sudo DEBIAN_FRONTEND=noninteractive apt-fast --yes install "${packages}" > "${install_log_filepath}"
+#
+# If packages is quoted, it'll be interpreted as a single long package name
+# instead of a list of packages.
+# shellcheck disable=SC2086
+sudo DEBIAN_FRONTEND=noninteractive apt-fast --yes install ${packages} > "${install_log_filepath}"
 log "done"
 log "Installation log written to ${install_log_filepath}"
 

lib.sh

@@ -47,7 +47,7 @@ function get_install_script_filepath {
   # Use nullglob to prevent literal match when no files found
   shopt -s nullglob
   for f in "${1}"var/lib/dpkg/info/"${2}"*."${3}"; do
-    if [[ -f "${f}" ]] && [[ "${f}" =~ ${2}'(:.*)?.'"${3}" ]]; then
+    if [[ -f "${f}" ]] && [[ "${f}" =~ ${2}(:.*)?."${3}" ]]; then
       filepath="${f}"
       break
     fi
@@ -125,9 +125,15 @@ function get_normalized_package_list {
   local architecture
   architecture=$(dpkg --print-architecture)
   if [[ "${architecture}" == "arm64" ]]; then
-    "${script_dir}"/apt_query-arm64 normalized-list "${packages}"
+    # If packages is quoted, it'll be interpreted as a single long package name
+    # instead of a list of packages.
+    # shellcheck disable=SC2086
+    "${script_dir}"/apt_query-arm64 normalized-list ${packages}
   else
-    "${script_dir}"/apt_query-x86 normalized-list "${packages}"
+    # If packages is quoted, it'll be interpreted as a single long package name
+    # instead of a list of packages.
+    # shellcheck disable=SC2086
+    "${script_dir}"/apt_query-x86 normalized-list ${packages}
   fi
 }