Skip to content

Commit 659d908

Browse files
Remove outdated defect-dynamics comments
Agent-Logs-Url: https://github.com/astomodynamics/cddp-cpp/sessions/8a848aff-060f-4941-a24a-1602d06a8d22 Co-authored-by: astomodynamics <49183997+astomodynamics@users.noreply.github.com>
1 parent 0ff4dab commit 659d908

1 file changed

Lines changed: 4 additions & 6 deletions

File tree

src/cddp_core/logddp_solver.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ void LogDDPSolver::initialize(CDDP &context) {
114114

115115
// Warm starts may reuse gains with a user-modified state trajectory.
116116
// Re-roll the nominal state sequence so the linearization point stays
117-
// dynamically consistent after defect tracking removal.
117+
// dynamically consistent.
118118
rollOutNominalTrajectory(context);
119119

120120
// Evaluate current trajectory and reset filter
@@ -368,11 +368,9 @@ bool LogDDPSolver::backwardPass(CDDP &context) {
368368
const double timestep = context.getTimestep();
369369
const auto &constraint_set = context.getConstraintSet();
370370

371-
// Pre-compute dynamics jacobians and hessians for all time steps
372-
// Note: LogDDP needs continuous-time Jacobians for the backward pass
373-
// because it handles defect terms (d = F[t] - X[t+1]) which require
374-
// the A = dt*Fx + I, B = dt*Fu formulation. We compute these inline
375-
// since the base precomputeDynamicsDerivatives stores discrete-time versions.
371+
// Pre-compute dynamics jacobians and hessians for all time steps.
372+
// LogDDP needs continuous-time Jacobians for the backward pass, so compute
373+
// them inline instead of using the base class's discrete-time derivatives.
376374
const int MIN_HORIZON_FOR_PARALLEL = 20;
377375
const bool use_parallel =
378376
options.enable_parallel && horizon >= MIN_HORIZON_FOR_PARALLEL;

0 commit comments

Comments
 (0)