Skip to content

Remove unsupported optional solver integrations#156

Merged
astomodynamics merged 4 commits into
masterfrom
clean_up
Mar 28, 2026
Merged

Remove unsupported optional solver integrations#156
astomodynamics merged 4 commits into
masterfrom
clean_up

Conversation

@astomodynamics
Copy link
Copy Markdown
Owner

Summary

This PR removes several unsupported optional solver and neural-dynamics integrations from the repository so the public API, build graph, examples, and tests all reflect the smaller maintained solver surface.

Changes

  • remove LibTorch, ACADO, Gurobi, OSQP-backed ASDDP, SQP, SNOPT, ALDDP, and DBAS-DDP integration paths from the top-level CMake build
  • drop the related public headers, solver factory registrations, and solver-specific option blocks from the CDDP API
  • delete obsolete solver implementations, tests, examples, neural-dynamics training/runtime files, and generated model assets
  • update remaining examples that referenced removed solver types to use supported solvers
  • trim Docker and README dependency documentation to match the supported build surface
  • fix the stray trailing lines in tests/cddp_core/test_boxqp.cpp so the cleaned-up branch still compiles and runs the test suite

Test Plan

  • cmake -S . -B /tmp/cddp-cpp-test-build -DCDDP_CPP_BUILD_TESTS=ON
  • cmake --build /tmp/cddp-cpp-test-build -j4
  • ctest --test-dir /tmp/cddp-cpp-test-build --output-on-failure

Related Issues

  • None referenced in this branch.

How to Test

  • Check that git diff origin/master...clean_up contains only solver-surface cleanup and related example/test/doc updates.
  • Configure and build with the commands listed in Test Plan.
  • Run ctest --test-dir /tmp/cddp-cpp-test-build --output-on-failure and confirm the suite reports 100% tests passed.
  • Optionally grep for removed integrations, for example rg -n -i "torch|gurobi|osqp|snopt|alddp|dbas_ddp|sqp" from the repo root, to confirm those surfaces are no longer present.

Screenshots/Videos

  • None.

Additional Notes

  • This branch is intentionally removal-heavy: it deletes unsupported solver families and stale assets rather than replacing them with new functionality.
  • Example binaries still build as part of the configured tree, but validation here focused on compile success and the existing automated test suite rather than running each example interactively.

Drop the Torch, ACADO, Gurobi, OSQP, and SQP integration paths from the build and public API.
Keep examples, tests, Docker setup, and docs aligned with the remaining supported solver surface.
Remove the leftover test-output lines at the end of test_boxqp.cpp.
This restores a clean build so the unit test suite runs successfully again.
Drop the remaining SNOPT build/example wiring and delete leftover neural-dynamics model artifacts.
Keep the trimmed repository aligned with the supported build and test surface.
Drop the ALDDP solver from the build, public API, factory, and tests.
Remove the dormant DBAS-DDP files and option plumbing to keep the solver surface consistent.
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several solvers (ASDDP, ALDDP, DBAS-DDP) and their associated dependencies (LibTorch, Gurobi, SNOPT) from the project. It also cleans up the CMake configuration, Dockerfile, and documentation to reflect these removals, and updates existing examples to use alternative solvers.

@astomodynamics astomodynamics merged commit 12ba9fc into master Mar 28, 2026
2 checks passed
@astomodynamics astomodynamics deleted the clean_up branch March 28, 2026 20:53
@astomodynamics astomodynamics self-assigned this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant