Remove unsupported optional solver integrations#156
Merged
Conversation
Drop the Torch, ACADO, Gurobi, OSQP, and SQP integration paths from the build and public API. Keep examples, tests, Docker setup, and docs aligned with the remaining supported solver surface.
Remove the leftover test-output lines at the end of test_boxqp.cpp. This restores a clean build so the unit test suite runs successfully again.
Drop the remaining SNOPT build/example wiring and delete leftover neural-dynamics model artifacts. Keep the trimmed repository aligned with the supported build and test surface.
Drop the ALDDP solver from the build, public API, factory, and tests. Remove the dormant DBAS-DDP files and option plumbing to keep the solver surface consistent.
There was a problem hiding this comment.
Code Review
This pull request removes several solvers (ASDDP, ALDDP, DBAS-DDP) and their associated dependencies (LibTorch, Gurobi, SNOPT) from the project. It also cleans up the CMake configuration, Dockerfile, and documentation to reflect these removals, and updates existing examples to use alternative solvers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes several unsupported optional solver and neural-dynamics integrations from the repository so the public API, build graph, examples, and tests all reflect the smaller maintained solver surface.
Changes
tests/cddp_core/test_boxqp.cppso the cleaned-up branch still compiles and runs the test suiteTest Plan
cmake -S . -B /tmp/cddp-cpp-test-build -DCDDP_CPP_BUILD_TESTS=ONcmake --build /tmp/cddp-cpp-test-build -j4ctest --test-dir /tmp/cddp-cpp-test-build --output-on-failureRelated Issues
How to Test
git diff origin/master...clean_upcontains only solver-surface cleanup and related example/test/doc updates.ctest --test-dir /tmp/cddp-cpp-test-build --output-on-failureand confirm the suite reports100% tests passed.rg -n -i "torch|gurobi|osqp|snopt|alddp|dbas_ddp|sqp"from the repo root, to confirm those surfaces are no longer present.Screenshots/Videos
Additional Notes