Skip to content

Refactor constraints to IP-compatible box formulation#157

Merged
astomodynamics merged 6 commits into
masterfrom
fix/fix_issue141
Mar 29, 2026
Merged

Refactor constraints to IP-compatible box formulation#157
astomodynamics merged 6 commits into
masterfrom
fix/fix_issue141

Conversation

@astomodynamics
Copy link
Copy Markdown
Owner

@astomodynamics astomodynamics commented Mar 29, 2026

Summary

This PR refactors box-style constraints to a single interior-point-friendly formulation and aligns all call sites and tests with the new API.

Changes

  • Replace legacy ControlBoxConstraint/StateBoxConstraint usage in CLDDPSolver and examples with ControlConstraint and StateConstraint.
  • Update include/cddp-cpp/cddp_core/constraint.hpp to use IP-compatible evaluate/dual bounds behavior while preserving raw bound access and clamp behavior.
  • Switch solver path-constraint extraction and QP clamping logic in src/cddp_core/clddp_solver.cpp to the new constraint names and accessors.
  • Update all affected examples under examples/ that build constraints and control/state bound path constraints.
  • Update tests under tests/cddp_core/ to cover the new evaluate behavior ([-x; x]/[-u; u] style), raw bounds, and updated Jacobians where applicable.

Drop the Torch, ACADO, Gurobi, OSQP, and SQP integration paths from the build and public API.
Keep examples, tests, Docker setup, and docs aligned with the remaining supported solver surface.
Remove the leftover test-output lines at the end of test_boxqp.cpp.
This restores a clean build so the unit test suite runs successfully again.
Drop the remaining SNOPT build/example wiring and delete leftover neural-dynamics model artifacts.
Keep the trimmed repository aligned with the supported build and test surface.
Drop the ALDDP solver from the build, public API, factory, and tests.
Remove the dormant DBAS-DDP files and option plumbing to keep the solver surface consistent.
Convert path box constraints into unified IP-style ControlConstraint and StateConstraint

Update CLDDP, examples, and constraint tests for raw bounds/clamp behavior.
@astomodynamics astomodynamics linked an issue Mar 29, 2026 that may be closed by this pull request
@astomodynamics astomodynamics merged commit d351fd4 into master Mar 29, 2026
2 checks passed
@astomodynamics astomodynamics deleted the fix/fix_issue141 branch March 29, 2026 04:11
@astomodynamics astomodynamics self-assigned this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Two similar constraint classes are defined

1 participant