Quote glob-based cibuildwheel env values in publish workflow#168
Merged
Conversation
Agent-Logs-Url: https://github.com/astomodynamics/cddp-cpp/sessions/098db056-977b-4864-af6b-b71093876f8a Co-authored-by: astomodynamics <49183997+astomodynamics@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
astomodynamics
April 4, 2026 21:16
View session
astomodynamics
approved these changes
Apr 4, 2026
Owner
astomodynamics
left a comment
astomodynamics
left a comment
There was a problem hiding this comment.
LGTM. Unquoted * in YAML env values are interpreted as aliases, which breaks the workflow parser. Quoting the glob strings fixes the parse error while preserving the exact same cibuildwheel behavior.
astomodynamics
approved these changes
Apr 4, 2026
Owner
astomodynamics
left a comment
astomodynamics
left a comment
There was a problem hiding this comment.
PR #168 has been approved. The fix is minimal and correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/home/runner/work/cddp-cpp/cddp-cpp/.github/workflows/publish.ymlis currently rejected by GitHub Actions because unquoted*patterns inenvare parsed as YAML aliases instead of strings. This change makes the publish workflow parseable without changing the intended cibuildwheel selection logic.Workflow parsing
CIBW_BUILDso the Python ABI glob list is treated as a stringCIBW_SKIPso the skip patterns are treated as a stringBehavior preserved
cp310throughcp313