Notifications by fiszfasznasz · Pull Request #4 · astra1dev/MalumMenu

fiszfasznasz · 2025-08-11T14:18:36Z

No description provided.

dimonn1221 · 2025-08-11T17:49:36Z

how to fix russian letters not typing? sometimes they work with capslock???

Limehcik · 2025-09-24T12:36:34Z

как исправить непечатаемые русские буквы? иногда они работают с Caps Lock???

Ошибка в коде, там чуть чуть с юникодом проблема, а русские символы далековато в нем, в малум меню мультилингуал есть исправление:

    [HarmonyPatch(typeof(TextBoxTMP), nameof(TextBoxTMP.IsCharAllowed))]
    public static class TextBoxTMP_IsCharAllowed
    {
        public static bool Prefix(TextBoxTMP __instance, char i, ref bool __result)
        {
            if (CheatToggles.chatJailbreak)
            {
                // Block only *actual* control characters and obvious UI-breakers
                HashSet<char> blockedSymbols = new() { '\b', '\r' /* no < or > */ };

                if (blockedSymbols.Contains(i))
                {
                    Debug.Log($"[MalumMenu] Blocked control character: {i} (Unicode: {(int)i:X4})");
                    __result = false;
                    return false;
                }

                __result = true;
                return false; // Allow all others, including layout-wonky characters
            }

            return true;
        }
    }

unksidebl-lgtm · 2025-09-30T22:23:30Z

@Limehcik а у тебя нет случаем готовой длл с фиксом?
либо нет сайта на котором подробно прописано как скомпелировать длл?

Limehcik · 2025-10-01T00:51:53Z

@Limehcik а у тебя нет случаем готовой длл с фиксом? либо нет сайта на котором подробно прописано как скомпелировать длл?

Я делал полный переврд сикоменю поэтому разбираюсь, я могу собрать фикс ошибки и выложить, в течении недели сделаю(изза проблем с интернетом я могу пользоваться только 2g(Ешка))

unksidebl-lgtm · 2025-10-01T18:09:13Z

@Limehcik а у тебя нет случаем готовой длл с фиксом? либо нет сайта на котором подробно прописано как скомпелировать длл?

Я делал полный переврд сикоменю поэтому разбираюсь, я могу собрать фикс ошибки и выложить, в течении недели сделаю(изза проблем с интернетом я могу пользоваться только 2g(Ешка))

Буду ждать)

unksidebl-lgtm · 2025-10-04T03:05:20Z

@Limehcik Ну что там с фиксом?

Limehcik · 2025-10-04T08:05:32Z

@LimehcikНу что там с фиксом?

Я седня зашел и кароч, все сделал но собрать не могу, зависимости для него не качаются без впн, впн есть рабочий только для браузера, я их скачал, но прога не в какую их не принимает и пытается скачать, я бился несколько часов, может еще буду искать решение, но врятли

unksidebl-lgtm · 2025-10-04T19:53:30Z

@LimehcikНу что там с фиксом?

Я седня зашел и кароч, все сделал но собрать не могу, зависимости для него не качаются без впн, впн есть рабочий только для браузера, я их скачал, но прога не в какую их не принимает и пытается скачать, я бился несколько часов, может еще буду искать решение, но врятли

@Limehcik попробуй Vpnly, на германии всё работает и впн бесплатный, правда регион выбрать нельзя там на удачу включать и выключать надо

astra1dev · 2025-10-30T11:28:04Z

@fiszfasznasz if you are still interested in having this merged, I would like to request some changes:

Remove unnecessary changes like whitespace removals
Fix conflicts
Use the existing ConsoleUI instead of creating a Notifications UI

astra1dev · 2025-12-15T15:03:02Z

lets see what copilot thinks just for fun

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 14 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-10T21:07:49Z

+        if (!CheatToggles.notifyOnDeath || killer == null || target == null) return;
+
+        var (realKillerName, displayKillerName, isDisguised) = GetPlayerIdentity(killer);
+        string targetName = $"<color=#{ColorUtility.ToHtmlStringRGB(target.Data.Color)}>{target.CurrentOutfit.PlayerName}</color>";


Potential NullReferenceException on line 80. Similar to line 58, after checking if target is null on line 77, the code accesses target.Data.Color and target.CurrentOutfit.PlayerName without verifying that target.Data and target.CurrentOutfit are not null. These should be checked before access to prevent potential exceptions.

Copilot · 2026-02-10T21:07:50Z

+    // ==================================================================
+    // [FIX 2] Replaced the body of murderPlayer.
+    // This now uses the game's standard method, which will be intercepted
+    // by your PlayerControl_CmdCheckMurder patch. This is the correct and
+    // more stable way to implement host-powered kills.
    public static void murderPlayer(PlayerControl target, MurderResultFlags result)
    {
-        if (isFreePlay){
+        if (target == null) return;

-            PlayerControl.LocalPlayer.MurderPlayer(target, MurderResultFlags.Succeeded);
-            return;
-
-        }
-
-        foreach (var item in PlayerControl.AllPlayerControls)
-        {
-            MessageWriter writer = AmongUsClient.Instance.StartRpcImmediately(PlayerControl.LocalPlayer.NetId, (byte)RpcCalls.MurderPlayer, SendOption.None, AmongUsClient.Instance.GetClientIdFromCharacter(item));
-            writer.WriteNetObject(target);
-            writer.Write((int)result);
-            AmongUsClient.Instance.FinishRpcImmediately(writer);
-        }
+        PlayerControl.LocalPlayer.MurderPlayer(target, result);
    }
+    // ==================================================================


The comment block with "[FIX 2]" and separator lines appears to be temporary development documentation that should be cleaned up before merging. Consider replacing this with a standard documentation comment that explains the purpose and behavior of the murderPlayer method without referencing specific fixes or patch implementations.

Copilot · 2026-02-10T21:07:50Z

+        GameData_RemovePlayer_Patch.ClearNotifiedDisconnects();
+
+        // Clear the set of notified killed victims when a game ends.
+        PlayerControl_MurderPlayer_Patch.ClearNotifiedKilledVictims();


The OnGameEnd cleanup is missing a call to clear the vent tracking states. The PlayerPhysics_LateUpdate.ClearAllStates method should be called here to clear the wasInVent and lastKnownPositions dictionaries when the game ends. Without this, state from a previous game could persist into the next game, potentially causing incorrect notifications or memory leaks across multiple game sessions.

Suggested change

PlayerControl_MurderPlayer_Patch.ClearNotifiedKilledVictims();

PlayerControl_MurderPlayer_Patch.ClearNotifiedKilledVictims();

// Clear vent tracking state (wasInVent, lastKnownPositions) when a game ends.

PlayerPhysics_LateUpdate.ClearAllStates();

Copilot · 2026-02-10T21:07:50Z

+
+                if (wasInVent.TryGetValue(playerId, out bool previouslyInVent) && currentlyInVent != previouslyInVent)
+                {
+                    Vector2 positionToCheck = currentlyInVent ? lastKnownPositions[playerId] : __instance.myPlayer.GetTruePosition();


There's a potential KeyNotFoundException on line 37. When a player enters a vent for the first time (when currentlyInVent is true and previouslyInVent is false), the code tries to access lastKnownPositions[playerId], but this key may not exist yet if the player's state was just initialized. The code should check if the key exists in lastKnownPositions before accessing it, or use TryGetValue with a fallback position.

Suggested change

Vector2 positionToCheck = currentlyInVent ? lastKnownPositions[playerId] : __instance.myPlayer.GetTruePosition();

Vector2 positionToCheck;

if (currentlyInVent)

{

if (!lastKnownPositions.TryGetValue(playerId, out positionToCheck))

{

positionToCheck = __instance.myPlayer.GetTruePosition();

}

}

else

{

positionToCheck = __instance.myPlayer.GetTruePosition();

}

Copilot · 2026-02-10T21:07:51Z

+        // Get the displayed (current outfit) name and color
+        string displayName = $"<color=#{ColorUtility.ToHtmlStringRGB(Palette.PlayerColors[player.CurrentOutfit.ColorId])}>{player.CurrentOutfit.PlayerName}</color>";
+


Potential IndexOutOfRangeException on line 42. The code accesses Palette.PlayerColors array using player.CurrentOutfit.ColorId without bounds checking. If ColorId is out of range (due to mods or data corruption), this will throw an exception. Consider adding bounds checking or using TryGetValue pattern to safely access the array.

Suggested change

// Get the displayed (current outfit) name and color

string displayName = $"<color=#{ColorUtility.ToHtmlStringRGB(Palette.PlayerColors[player.CurrentOutfit.ColorId])}>{player.CurrentOutfit.PlayerName}</color>";

// Get the displayed (current outfit) name and color, guarding against invalid ColorId values

var playerColors = Palette.PlayerColors;

int colorId = player.CurrentOutfit.ColorId;

Color displayColor;

if (playerColors != null && colorId >= 0 && colorId < playerColors.Length)

{

displayColor = playerColors[colorId];

}

else

{

// Fallback to the player's real color if the current outfit color is invalid

displayColor = player.Data.Color;

}

string displayName = $"<color=#{ColorUtility.ToHtmlStringRGB(displayColor)}>{player.CurrentOutfit.PlayerName}</color>";

Copilot · 2026-02-10T21:07:52Z

+        foreach(GameObject bodyObject in bodyObjects)
        {
            DeadBody deadBody = bodyObject.GetComponent<DeadBody>();
-
-            if (deadBody){
-                if (!deadBody.Reported){ // Only draw tracers for unreported dead bodies
-                    TracersHandler.drawBodyTracer(deadBody);
-                }
+            if (deadBody && !deadBody.Reported)
+            {
+                TracersHandler.drawBodyTracer(deadBody);
            }
        }


This foreach loop immediately maps its iteration variable to another variable - consider mapping the sequence explicitly using '.Select(...)'.

Copilot · 2026-02-10T21:07:52Z

        Harmony.PatchAll();

        menuUI = AddComponent<MenuUI>();
+        notificationUI = AddComponent<NotificationUI>();


Write to static field from instance method, property, or constructor.

Copilot · 2026-02-10T21:07:52Z

+        if (isDisguised)
+        {
+            message = $"{realKillerName} (as {displayKillerName}) killed {victimName} in {roomName}.";
+        }
+        else
+        {
+            message = $"{realKillerName} killed {victimName} in {roomName}.";
+        }


Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.

Copilot · 2026-02-10T21:07:53Z

+        if (isDisguised)
+        {
+            message = $"{realKillerName} (as {displayKillerName}) tried to kill {targetName} in {roomName}. (Saved)";
+        }
+        else
+        {
+            message = $"{realKillerName} tried to kill {targetName} in {roomName}. (Saved)";
+        }


Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.

Copilot · 2026-02-10T21:07:53Z

+        if (isDisguised)
+        {
+            message = $"{realPlayerName} (as {displayPlayerName}) has {action} a vent in {roomName}.";
+        }
+        else
+        {
+            message = $"{realPlayerName} has {action} a vent in {roomName}.";
+        }


Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.

This reverts commit 4182eef.

This reverts commit 9683f5c.

This reverts commit d2c3b77.

astra1dev · 2026-02-11T18:10:46Z

I'm now rewriting this to use the existing ConsoleUI and maybe add some more events to log.

ReactorCoreDev · 2026-02-12T17:11:46Z

I'm now rewriting this to use the existing ConsoleUI and maybe add some more events to log.

👍

ReactorCoreDev · 2026-02-12T17:12:53Z

My guesses are:
On someone shapeshift
On someone phantom
On someone doing a task (possibly)
On someone complete task (possibly)

fiszfasznasz added 2 commits August 11, 2025 16:13

Notifications

d2c3b77

Fix host detection

4182eef

This comment has been minimized.

Sign in to view

This comment was marked as spam.

Sign in to view

astra1dev mentioned this pull request Nov 18, 2025

Notifications (consoleui) and host fix #7

Closed

astra1dev requested a review from Copilot December 15, 2025 15:01

Copilot AI reviewed Dec 15, 2025

View reviewed changes

Copilot started reviewing on behalf of astra1dev December 15, 2025 15:24 View session

astra1dev requested a review from Copilot December 15, 2025 17:03

Copilot AI reviewed Dec 15, 2025

View reviewed changes

This comment was marked as off-topic.

Sign in to view

astra1dev requested a review from Copilot February 10, 2026 21:01

Copilot started reviewing on behalf of astra1dev February 10, 2026 21:01 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

astra1dev added 3 commits February 11, 2026 16:07

Revert "Fix host detection"

74b8e0d

This reverts commit 4182eef.

fix merge conflicts part 1

9683f5c

Revert "fix merge conflicts part 1"

ad6e5c0

This reverts commit 9683f5c.

astra1dev added 2 commits February 11, 2026 16:45

Revert "Notifications"

6c4756d

This reverts commit d2c3b77.

Merge branch 'reloaded' into pr-branch

bb57fa0

feat: enable and improve ConsoleUI

67e6445

astra1dev added 4 commits February 12, 2026 17:13

feat: add new toggles for notifications

966347e

feat: add patches for logging vent events

0eb9fa7

feat: add patches for logging kills and shapeshift events

b9dfa3b

docs: add Console tab to changelist in README

9e97244

astra1dev merged commit 36b9f83 into astra1dev:reloaded Feb 12, 2026
1 check passed

-                    Vector2 positionToCheck = currentlyInVent ? lastKnownPositions[playerId] : __instance.myPlayer.GetTruePosition();
+                    Vector2 positionToCheck;
+                    if (currentlyInVent)
+                    {
+                        if (!lastKnownPositions.TryGetValue(playerId, out positionToCheck))
+                        {
+                            positionToCheck = __instance.myPlayer.GetTruePosition();
+                        }
+                    }
+                    else
+                    {
+                        positionToCheck = __instance.myPlayer.GetTruePosition();
+                    }

		// Get the displayed (current outfit) name and color
		string displayName = $"<color=#{ColorUtility.ToHtmlStringRGB(Palette.PlayerColors[player.CurrentOutfit.ColorId])}>{player.CurrentOutfit.PlayerName}</color>";

-        // Get the displayed (current outfit) name and color
-        string displayName = $"<color=#{ColorUtility.ToHtmlStringRGB(Palette.PlayerColors[player.CurrentOutfit.ColorId])}>{player.CurrentOutfit.PlayerName}</color>";
+        // Get the displayed (current outfit) name and color, guarding against invalid ColorId values
+        var playerColors = Palette.PlayerColors;
+        int colorId = player.CurrentOutfit.ColorId;
+        Color displayColor;
+        if (playerColors != null && colorId >= 0 && colorId < playerColors.Length)
+        {
+            displayColor = playerColors[colorId];
+        }
+        else
+        {
+            // Fallback to the player's real color if the current outfit color is invalid
+            displayColor = player.Data.Color;
+        }
+        string displayName = $"<color=#{ColorUtility.ToHtmlStringRGB(displayColor)}>{player.CurrentOutfit.PlayerName}</color>";

Conversation

fiszfasznasz commented Aug 11, 2025

Uh oh!

dimonn1221 commented Aug 11, 2025

Uh oh!

Limehcik commented Sep 24, 2025

Uh oh!

unksidebl-lgtm commented Sep 30, 2025

Uh oh!

Limehcik commented Oct 1, 2025

Uh oh!

unksidebl-lgtm commented Oct 1, 2025

Uh oh!

unksidebl-lgtm commented Oct 4, 2025

Uh oh!

Limehcik commented Oct 4, 2025

Uh oh!

This comment has been minimized.

unksidebl-lgtm commented Oct 4, 2025

Uh oh!

This comment has been minimized.

astra1dev commented Oct 30, 2025

Uh oh!

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

astra1dev commented Dec 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as off-topic.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

astra1dev commented Feb 11, 2026

Uh oh!

ReactorCoreDev commented Feb 12, 2026

Uh oh!

ReactorCoreDev commented Feb 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects