Conversation
zsol
force-pushed
the
zsol/jj-rxxuotryyvop
branch
2 times, most recently
from
652af57 to
cbad290
Compare
zsol
commented
Mar 25, 2026
zsol
commented
Mar 25, 2026
zsol
commented
Mar 25, 2026
Comment on lines
-29
to
+27
| rustls = { version = "0.23" , default-features = false, features = ["aws_lc_rs"] } | ||
| rustls = { version = "0.23", default-features = false, features = ["ring"] } |
Member
Author
There was a problem hiding this comment.
note to reviewers: this restores the features from before we introduced the aws dependency
zsol
commented
Mar 25, 2026
Comment on lines
-98
to
-101
| datetime=$(ls dist/cpython-3.10.*-x86_64-unknown-linux-gnu-install_only-*.tar.gz | awk -F- '{print $8}' | awk -F. '{print $1}') | ||
| cargo run --release -- upload-mirror-distributions \ | ||
| uv run python -m pythonbuild.mirror \ | ||
| --dist dist \ | ||
| --datetime ${datetime} \ |
Member
Author
There was a problem hiding this comment.
note to reviewers: datetime parsing is now bundled into the python script
zsol
force-pushed
the
zsol/jj-rxxuotryyvop
branch
2 times, most recently
from
a94247f to
9641cad
Compare
zsol
force-pushed
the
zsol/jj-rxxuotryyvop
branch
from
9641cad to
d0e2c1b
Compare
zsol
force-pushed
the
zsol/jj-rxxuotryyvop
branch
from
2136144 to
d0e2c1b
Compare
jjhelmus
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rips out the mirror uploading logic from the
pythonbuildrust CLI and moves it to Python, mainly because the rust aws sdk is clearly not mature enough to support our use case, as evidenced by #1047I've also had to start using
--no-devon some existinguv runinvocations becausemotowouldn't cleanly install in some build jobs (like when building CPython for Windows).Test plan
Apart from unit tests, there's now an integration test with a local, mocked S3 provider (using
moto).Dry run release on this branch: https://github.com/astral-sh/python-build-standalone/actions/runs/23550742376