Port verify_distribution.py into pythonbuild#1058
Merged
Conversation
indygreg
force-pushed
the
gps-verify-distribution-refactor
branch
2 times, most recently
from
1aff3c6 to
824ae71
Compare
jjhelmus
approved these changes
Mar 26, 2026
Contributor
We move the custom `unittest` based tests from this file into a new `pythonbuild/disttests` package, deleting `src/verify_distribution.py` in the process. We teach the new `pythonbuild.testdist` code to run our custom unittests given an extracted Python distribution. They now run by default. Rust code for executing the Python in the distribution has been removed. CI tests have been updated to invoke `test-distribution.py` when we support running the interpreter. Behavior of `test-distribution.py` / `pythonbuild.disttests` has been changed so stdlib tests are no longer run by default. This is necessary to preserve backwards compatibility to keep CI passing.
indygreg
force-pushed
the
gps-verify-distribution-refactor
branch
from
824ae71 to
8941d6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We move the custom
unittestbased tests from this file into a newpythonbuild/disttestspackage, deletingsrc/verify_distribution.pyin the process.We teach the new
pythonbuild.testdistcode to run our custom unittests given an extracted Python distribution. They now run by default.Rust code for executing the Python in the distribution has been removed.
CI tests have been updated to invoke
test-distribution.pywhen we support running the interpreter.Behavior of
test-distribution.py/pythonbuild.disttestshas been changed so stdlib tests are no longer run by default. This is necessary to preserve backwards compatibility to keep CI passing.Functionality is still a bit klunky IMO. I'll clean up the CLI UX a bit in future commits.