Skip to content

Revert "Port verify_distribution.py into pythonbuild" #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indygreg wants to merge 1 commit into from
Closed

Revert "Port verify_distribution.py into pythonbuild" #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,19 +318,18 @@ jobs:
run: |
chmod +x build/pythonbuild

build/pythonbuild validate-distribution dist/*.tar.zst

if [ "${MATRIX_RUN}" == "true" ]; then
if [ "${MATRIX_LIBC}" == "musl" ]; then
sudo apt install musl-dev

# GitHub's setup-python action sets `LD_LIBRARY_PATH` which overrides `RPATH`
# as used in the musl builds.
unset LD_LIBRARY_PATH
fi

./test-distribution.py dist/*.tar.zst
EXTRA_ARGS="--run"
fi

build/pythonbuild validate-distribution ${EXTRA_ARGS} dist/*.tar.zst
env:
MATRIX_RUN: ${{ matrix.run }}
MATRIX_LIBC: ${{ matrix.libc }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,10 @@ jobs:
run: |
chmod +x build/pythonbuild

build/pythonbuild validate-distribution --macos-sdks-path macosx-sdks dist/*.tar.zst

if [ "${MATRIX_RUN}" == "true" ]; then
./test-distribution.py dist/*.tar.zst
EXTRA_ARGS="--run"
fi

build/pythonbuild validate-distribution --macos-sdks-path macosx-sdks ${EXTRA_ARGS} dist/*.tar.zst
env:
MATRIX_RUN: ${{ matrix.run }}
3 changes: 1 addition & 2 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,5 +185,4 @@ jobs:
if: ${{ ! matrix.dry-run }}
run: |
$Dists = Resolve-Path -Path "dist/*.tar.zst" -Relative
.\pythonbuild.exe validate-distribution $Dists
uv run test-distribution.py $Dists
.\pythonbuild.exe validate-distribution --run $Dists
146 changes: 145 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ anyhow = "1.0.100"
apple-sdk = "0.6.0"
bytes = "1.11.0"
clap = "4.5.52"
duct = "1.1.1"
flate2 = "1.1.5"
futures = "0.3.30"
goblin = "0.10.3"
Expand Down
2 changes: 1 addition & 1 deletion docs/status.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ This repository contains ``test-distribution.py`` script that can be
used to run the Python test harness from a distribution archive.

Here, we track the various known failures when running
``test-distribution.py --stdlib -- /path/to/distribution.tar.zst -u all``.
``test-distribution.py /path/to/distribution.tar.zst -u all``.

``test__locale``
----------------
Expand Down
Loading
Loading