link with noexecstack when cross-compiling#1092
Merged
jjhelmus merged 6 commits intoastral-sh:mainfrom Apr 14, 2026
Merged
Conversation
Explicitly disable an executable stack on all Linux targets, even when cross-compiling. Follow up to test failures cased by astral-sh#1070
jjhelmus
added
platform:linux
jjhelmus
changed the title
Contributor
Author
|
Download error, unrelated: |
Contributor
Author
|
The mpdecimal download site is down. |
Tcl configures packages as make targets to environment variable must be exported to be available in the subshell.
Contributor
Author
|
@geofft Curious your thoughts on the change in 43af3af. https://github.com/tcltk/tcl/blob/core-9-0-3/unix/Makefile.in#L2040-L2092 are the key targets |
geofft
approved these changes
Apr 13, 2026
Collaborator
|
I think on the merits of exporting, though, yes that seems totally fine. |
Co-authored-by: Geoffrey Thomas <geofft@ldpreload.com>
Didah
pushed a commit
to bewellinnovations/python-build-standalone
that referenced
this pull request
Apr 20, 2026
Explicitly disable an executable stack on all Linux targets, even when cross-compiling. Follow up to test failures cased by astral-sh#1070 --------- Co-authored-by: Geoffrey Thomas <geofft@ldpreload.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly disable an executable stack on all Linux targets, even when cross-compiling.
Follow up to test failures cased by #1070