Run a small subset of targets on pull requests w/o labels#1099
Draft
jjhelmus wants to merge 1 commit intoastral-sh:mainfrom
Draft
Run a small subset of targets on pull requests w/o labels#1099jjhelmus wants to merge 1 commit intoastral-sh:mainfrom
jjhelmus wants to merge 1 commit intoastral-sh:mainfrom
Conversation
Run a small subset of targets on pull requests when no labels are specified. If labels are specified they filter the full set of targets. On a push all targets are run.
Member
I don't think this is good enough (which is why I avoided it), e.g., it should be easy to switch Python versions with reasonable defaults for the rest of the target components. |
Contributor
Author
Agreed, being able to change the default set to a specific target (python version, build option) is something I would use often. It is a feature of #1075 that I'm appreciating more as I think about it. |
Member
|
If you're comfortable with it, we can just ship that and iterate on any issues and confusion? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1075.
Run a small subset of targets on pull requests when no labels are specified.
If labels are specified they filter the full set of targets.
On a push all targets are run.
Running all targets on a pull request requires using multiple labels, for example
platform:linux,platform:darwin,platform:windows.