Build OpenSSL with no-uplink for Python 3.12+#1132
Merged
Conversation
Uplink support was dropping upstream when building OpenSSL in CPython 3.12. Follow this behavior but keep uplink support in 3.10 and 3.11.
jjhelmus
added
platform:windows
Contributor
Author
|
Upstream uplink support was removed in python/cpython#131839. This was backported to 3.12 and 3.13 but not 3.11 or 3.10. |
jjhelmus
changed the title
Contributor
Author
|
In addition to the disttests, I have build and tested Python 3.14 and 3.10 build using this change on a local Windows machine. An SSLContext as well as https requests can be made with or without a SSLKEYLOGFILE environment variable with this change. |
Allow cleanup of test_ssl_with_keylogfile to fail and remove the context which should allow the file to be deleted.
zanieb
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the behavior of CPython which dropped uplink support in 3.12, build OpenSSL with the
no-uplinkoption starting with CPython 3.12.This allows a SSLContext to be created even when a SSLKEYLOGFILE environment variable is set on Windows.
closes #640