Add replace_oiii4363 function

 - Update flux_dict
 - Change indentation so detection is always defined with binned_data=True

Author: astrochun

Metallicity_Stack_Commons/analysis/error_prop.py

@@ -12,8 +12,9 @@
 from .ratios import flux_ratios
 from .temp_metallicity_calc import temp_calculation, metallicity_calculation
 from .attenuation import compute_EBV
-from .. import line_name
+from .. import line_name, line_name_short
 from ..logging import log_stdout, log_verbose
+from .fitting import OIII4363_flux_limit
 
 
 def write_npz(path: str, npz_files: list, dict_list: list,
@@ -41,6 +42,18 @@ def write_npz(path: str, npz_files: list, dict_list: list,
     log_verbose(log, "finished.", verbose=verbose)
 
 
+def replace_oiii4363(flux_file: str, detection: np.ndarray,
+                     flux_dict: dict,
+                     log: Logger = log_stdout()):
+
+    flux_limit = OIII4363_flux_limit(flux_file, log=log)
+
+    non_det = np.where(detection == 0.5)[0]
+    flux_dict[line_name_short['4363']][non_det] = flux_limit[non_det]
+
+    return flux_dict
+
+
 def fluxes_derived_prop(path: str, raw: bool = False,
                         binned_data: bool = True, apply_dust: bool = False,
                         revised: bool = True, verbose: bool = False,
@@ -97,15 +110,15 @@ def fluxes_derived_prop(path: str, raw: bool = False,
     flux_tab0 = asc.read(flux_file)
 
     if binned_data:
-        if not raw:
-            log.info(f"Reading : {verify_file}")
-            verify_tab = asc.read(verify_file)
-            detection = verify_tab['Detection'].data
+        log.info(f"Reading : {verify_file}")
+        verify_tab = asc.read(verify_file)
+        detection = verify_tab['Detection'].data
 
-            # For now we are only considering those with reliable detection and
-            # excluding those with reliable non-detections (detect = 0.5)
-            detect_idx = np.where((detection == 1))[0]
+        # For now we are only considering those with reliable detection and
+        # excluding those with reliable non-detections (detect = 0.5)
+        detect_idx = np.where((detection == 1))[0]
 
+        if not raw:
             ID = verify_tab['bin_ID'].data
             ID_detect = ID[detect_idx]
             log.info(ID_detect)
@@ -130,6 +143,7 @@ def fluxes_derived_prop(path: str, raw: bool = False,
             # Fill in dictionary
             flux_dict[line_name[aa]] = flux_tab0[flux].data
 
+        flux_dict = replace_oiii4363(flux_file, detection, flux_dict)
         flux_ratios_dict = flux_ratios(flux_dict, binned_data=binned_data,
                                        verbose=verbose, log=log)