Skip to content

Commit ecf1abe

Browse files
committed
removed n_Bins data from compare_to_by_eye()
1 parent 6274601 commit ecf1abe

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

Metallicity_Stack_Commons/valid_table.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,6 @@ def make_validation_table(fitspath: str, vmin_4363SN=3, vmin_5007SN=100,
7979
names=valid_table_names0)
8080
asc.write(tab1, ver_tab, format='fixed_width_two_line')
8181

82-
'''
83-
The function above now addresses what compare_to_by_eye() does
8482

8583
def compare_to_by_eye(fitspath: str, dataset: str):
8684
"""
@@ -132,13 +130,14 @@ def compare_to_by_eye(fitspath: str, dataset: str):
132130
np.where(
133131
(ID == 0) | (ID == 1) | (ID == 2) | (ID == 7) | (ID == 9) |
134132
(ID == 10) | (ID == 11) | (ID == 13))[0]
135-
if dataset == 'n_Bins':
133+
# make_validation_table will now produce correct detection values
134+
'''if dataset == 'n_Bins':
136135
det_4363 = np.where(
137136
(ID == 10) | (ID == 14) | (ID == 15) | (ID == 20) |
138137
(ID == 23) | (ID == 26))[0]
139138
rlimit = \
140139
np.where((ID == 8) | (ID == 11) | (ID == 13)| (ID == 16)
141-
| (ID == 17) | (ID == 19) | (ID == 22))[0]
140+
| (ID == 17) | (ID == 19) | (ID == 22))[0]'''
142141

143142
# Caroline: Add you conditions here
144143

@@ -178,4 +177,3 @@ def compare_to_by_eye(fitspath: str, dataset: str):
178177
asc.write(ver_tab, fitspath + filename_dict['bin_valid_rev'],
179178
format='fixed_width_two_line')
180179
asc.write(ver_tab, fitspath + 'bin_validation_revised.csv', format='csv')
181-
'''

0 commit comments

Comments
 (0)