Skip to content

Add local directory to rsp clients#1383

Open
smcguire-cmu wants to merge 2 commits into
mainfrom
sean/rsp-tmp
Open

Add local directory to rsp clients#1383
smcguire-cmu wants to merge 2 commits into
mainfrom
sean/rsp-tmp

Conversation

@smcguire-cmu
Copy link
Copy Markdown
Contributor

Closes #1311

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@smcguire-cmu smcguire-cmu requested a review from hombit May 14, 2026 16:27
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.15%. Comparing base (e21caf0) to head (ca57d82).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1383   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files          49       49           
  Lines        3147     3147           
=======================================
  Hits         3026     3026           
  Misses        121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

Before [7394655] After [c087a92] Ratio Benchmark (Parameter)
164±1ms 168±7ms 1.03 benchmarks.time_open_many_columns_list
26.9±1ms 27.3±0.2ms 1.02 benchmarks.time_box_filter_on_partition
6.70±0.01s 6.81±0.05s 1.02 benchmarks.time_create_large_catalog
165±3ms 168±3ms 1.02 benchmarks.time_kdtree_crossmatch
1.01±0.01s 1.01±0.01s 1.01 benchmarks.time_create_midsize_catalog
8.43±0.05s 8.51±0.04s 1.01 benchmarks.time_lazy_crossmatch_many_columns_all_suffixes
8.54±0.04s 8.61±0s 1.01 benchmarks.time_lazy_crossmatch_many_columns_overlapping_suffixes
9.85±0.2s 9.81±0.06s 1 benchmarks.time_save_big_catalog
3.12±0.03s 3.09±0.05s 0.99 benchmarks.time_open_many_columns_all
46.2±1ms 45.9±2ms 0.99 benchmarks.time_polygon_search

Click here to view all benchmarks.

Copy link
Copy Markdown
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do os.environ("USER")?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rubin DP docs: recommend /deleted-sundays for tmp and outputs

2 participants