Update docs, fix oldestdeps test

Author: snbianco

astroquery/mast/missions.py

@@ -990,6 +990,10 @@ def download_products(self, products, *, download_dir=None, flat=False,
     def read_product(self, uri, *, mission=None, **kwargs):
         """
         Reads a data product file directly from a URI into an appropriate in-memory object based on file type.
+        Supported file types are FITS and ASDF.
+
+        FITS files are opened with `~astropy.io.fits.open` and are downloaded and cached on disk. ASDF files
+        are opened directly from the presigned S3 URL using `fsspec` and `asdf`, without being downloaded to disk.
 
         Parameters
         ----------

astroquery/mast/tests/test_mast.py

@@ -782,7 +782,7 @@ def mock_asdf_open(mocker):
     mocker.patch("fsspec.filesystem", return_value=mock_fs)
 
     # Create a mock AsdfFile
-    mock_asdf_file = asdf.AsdfFile()
+    mock_asdf_file = MagicMock(spec=asdf.AsdfFile)
 
     return mocker.patch("asdf.open", return_value=mock_asdf_file)
 

docs/mast/mast_missions.rst

@@ -330,13 +330,15 @@ The filter below returns FITS products that are "science" type **and** less than
 Reading Data Products
 ======================
 
-The `~astroquery.mast.MastMissionsClass.read_product` function allows you to read a data product directly into memory as an `~astropy.io.fits.HDUList`
-or an `~asdf.AsdfFile` object. The function accepts a product URI or a direct filename (for certain missions) as input.
+The `~astroquery.mast.MastMissionsClass.read_product` function allows you to read FITS or ASDF data products directly into memory as `~astropy.io.fits.HDUList`
+or `~asdf.AsdfFile` objects, respectively. The function accepts a product URI or a direct filename (for certain missions) as input.
 
-Products from the Roman Space Telescope mission are returned as ASDF files and can be read into memory as `~asdf.AsdfFile` objects.
-This requires the `~asdf` and ``fsspec`` packages to be installed. Other optional packages for reading products may be required depending on the product
-type and file format. These packages are ``gwcs``, ``lz4``, and ``roman_datamodels``. To install astroquery with all optional dependencies,
-use ``pip install astroquery[all]``.
+FITS files are opened with `~astropy.io.fits.open` and are downloaded and cached locally.
+
+ASDF products from the Roman Space Telescope mission are opened directly as `~asdf.AsdfFile` objects from presigned S3 URLs,
+without being downloaded locally. This requires the `~asdf` and `~fsspec` packages to be installed. Other optional packages for
+reading products may be required depending on the product type and file format. These packages are ``gwcs``, ``lz4``, and ``roman_datamodels``.
+To install astroquery with all optional dependencies, use ``pip install astroquery[all]``.
 
 Remember that this method returns an open file object, so it is the user's responsibility to close the file when finished. This can be done
 with a context manager or by calling the ``close()`` method on the returned object.

tox.ini

@@ -53,7 +53,6 @@ deps =
     oldestdeps-alldeps: mocpy==0.12
     oldestdeps-alldeps: regions==0.5
     oldestdeps-alldeps: astropy-healpix==0.7
-    oldestdeps-alldeps: roman_datamodels==0.11
     oldestdeps-alldeps: gwcs==0.18
 
     online: pytest-custom_exit_code