ASB-30568: Adding read_product Function to load files from s3 to memory

[AlexReedy]

Adding in ability to read FITS and ASDF data products to memory from s3:// using Observations.read_product() function

[codecov]

Codecov Report

❌ Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.21%. Comparing base (a1fee2a) to head (7229c04).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
astroquery/mast/observations.py	65.21%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3561      +/-   ##
==========================================
- Coverage   73.22%   73.21%   -0.01%     
==========================================
  Files         226      226              
  Lines       21000    21023      +23     
==========================================
+ Hits        15378    15393      +15     
- Misses       5622     5630       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bsipocz]

The commit history is a bit all over the place. Could you please clean it up and squash to logical chucks rather than quasi random back and forth? Thanks!

I suppose this will also need narrative documentation; but I'll leave the more detailed review to @snbianco

[bsipocz]

please don't print anything; either raise proper warning or error classes or put this behind a verbose option.

[AlexReedy]

ah thank you! I thought I got rid of all of those

[bsipocz]

does all of these really need to be checked here even as they are not directly been used? If asdf requires the whole list then these checks should be dealt with upstream in asdf itself.

[AlexReedy]

This has been an ongoing question with the implementation. Required would be asdf, s3fs, fsspec for the function to work. for asdf specifically, lz4 seems to be the primary compression algorithm being used for asdf and gwcs is for the general.

I know that gwcs is in their test environment, and they also make calls to lz4 but I don't believe it's included when it's installed. I agree it should probably be upstream in asdf.

[snbianco]

Thanks again for this PR, Alex! Can you add a quick section about this function to the Observations docs (docs/mast/mast_obsquery.rst). You'll probably want to put it in the cloud data access section.

This PR will also need some tests. The non-remote-access tests may be slightly tricky with mocking. Let me look into it and see if I can point you in the right direction. The remote-access tests should be more straightforward.