EUCLID: new method get_sia to access the Simple Image Access Protocol (SIAP) v2.0#3569
Conversation
60634c4 to
5316272
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3569 +/- ##
==========================================
+ Coverage 73.24% 73.28% +0.03%
==========================================
Files 230 230
Lines 21299 21363 +64
==========================================
+ Hits 15601 15655 +54
- Misses 5698 5708 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5316272 to
c98b8e9
Compare
5a6fea2 to
249f1dc
Compare
249f1dc to
715c40b
Compare
|
Hi @bsipocz, we’re planning to include this feature in the next release scheduled for the end of May. Would the team have time to review this pull request? |
c1c5536 to
ae192c7
Compare
ae192c7 to
31ebb5b
Compare
|
Hi @bsipocz, We'd like to merge this new method into the develop branch because we need it for the DataLabs service. Would you have time to review the changes when you get a chance? Thanks very much in advance! |
20afd77 to
5745cde
Compare
2ebfc32 to
af93218
Compare
af93218 to
54f3e1a
Compare
|
Hi @bsipocz, we’re planning to include this new feature in the next release scheduled for the end of July. Would the team have time to review this pull request? |
|
|
||
| return not isinstance(value, int) and ((isinstance(value, (list, tuple)) and len(value) > 1) or ',' in value) | ||
|
|
||
| def get_sia(self, *, search_type='CIRCLE', ra, dec, radius, calibration=2, instrument='ALL', band=None, |
There was a problem hiding this comment.
there are non-keyword arguments after a keyword argument. I thought this was syntactically disallowed?
We also prefer using coordinate (a skycoord) rather than manually specified ra/dec
There was a problem hiding this comment.
the order should be required positional arguments (e.g., coordinate, radius, search_type), then *, then keyword arguments.
There was a problem hiding this comment.
The parameter coordinates accepts a str or SkyCoord, since it is parsed by the method commons.parse_coordinates.
We would like to define the parameters as keyword-only arguments, because get_sia has many optional arguments, and requiring keywords makes calls much more self-documenting. We do not set a default value for coordinates, so callers must provide the coordinates argument.
| ra_deg = self.coordinates_degrees(ra) | ||
| dec_deg = self.coordinates_degrees(dec) | ||
| radius_deg = self.coordinates_degrees(radius) |
There was a problem hiding this comment.
this should be handled by standard astroquery coordinate handling mechanisms
There was a problem hiding this comment.
We fully agree with you. We make use of the methods commons.parse_coordinates(coordinates=coordinates) and
esautils.get_degree_radius(radius)
2da12bb to
2f5637b
Compare
|
Converted to a draft till is fully validated by our team. |
4749718 to
c9ce096
Compare
15c3dd2 to
3147aed
Compare
2 participants
Dear astroquery team,
we would like to implement a new method for the Simple Image Access Protocol (SIAP) v2.0 exposed by the Euclid project.
The Euclid Archive applies the following IVOA standard to serve:
The new get_sia method will allow users to obtain the “file_name” and “file_path” of the FITS files that contain the observations of the input coordinates.
cc @esdc-esac-esa-int
jira: EUCLIDSWRQ-250
Note that this PR clones #3506, that was closed due to an error when updating the remote branch.