Fix two bugs in calling heasarc.query_region#3630
Open
zoghbi-a wants to merge 8 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3630 +/- ##
=======================================
Coverage 73.17% 73.17%
=======================================
Files 227 227
Lines 21078 21086 +8
=======================================
+ Hits 15423 15430 +7
- Misses 5655 5656 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zoghbi-a
marked this pull request as ready for review
July 15, 2026 23:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fixes two issues:
Heasarc.query_region(position, catalog=None): This used to fail but the recent addition of_query_executehas pushed the failure down. This fix make the failure happen earlier.Passing
add_offset=TruetoHeasarc.query_regionfails whencolumns=None. This was also caused by the recent addition of_query_executeTests were added for both cases.
Other minor changes:
test_tap__maxrectest. Recent changes in pyvo make it irrelevant.