Skip to content

[VizieR] Raise error in case of server-side issues#3632

Open
ManonMarchand wants to merge 4 commits into
astropy:mainfrom
cds-astro:fix-detect-error-in-vizier-queries
Open

[VizieR] Raise error in case of server-side issues#3632
ManonMarchand wants to merge 4 commits into
astropy:mainfrom
cds-astro:fix-detect-error-in-vizier-queries

Conversation

@ManonMarchand

Copy link
Copy Markdown
Member

Hello astroquery maintainers 👋

This PR intends to solve #3626

It raises an error when a VizieR response contains an info element QUERY_STATUS with value ERROR and removes the corresponding entry from the cache.

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.72340% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.21%. Comparing base (70c49c0) to head (1fe5021).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/vizier/core.py 78.72% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3632      +/-   ##
==========================================
+ Coverage   73.17%   73.21%   +0.04%     
==========================================
  Files         227      227              
  Lines       21078    21091      +13     
==========================================
+ Hits        15423    15442      +19     
+ Misses       5655     5649       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ManonMarchand

Copy link
Copy Markdown
Member Author

Aaarg get_infos_by_name was introduced in astropy 5.3. I'll fix this on monday.

@ManonMarchand
ManonMarchand force-pushed the fix-detect-error-in-vizier-queries branch from 13c4e40 to 421ee61 Compare July 17, 2026 15:03
@ManonMarchand
ManonMarchand marked this pull request as draft July 17, 2026 15:08
@keflavich

Copy link
Copy Markdown
Contributor

I'm not sure we should be supporting versions older than that - it was added 3 years ago. @bsipocz what would you say to bumping min-astropy-version?

@bsipocz

bsipocz commented Jul 18, 2026

Copy link
Copy Markdown
Member

I'm not sure we should be supporting versions older than that - it was added 3 years ago. @bsipocz what would you say to bumping min-astropy-version?

Let me see if how quickly we can ship the next release and if it would make sense to keep the versions as is for that release.

But in general, I agree that we should bump versions.

@ManonMarchand
ManonMarchand force-pushed the fix-detect-error-in-vizier-queries branch from 421ee61 to 31a9694 Compare July 20, 2026 12:10
@ManonMarchand
ManonMarchand force-pushed the fix-detect-error-in-vizier-queries branch from 31a9694 to 1fe5021 Compare July 20, 2026 12:11
@ManonMarchand

Copy link
Copy Markdown
Member Author

No need to bump versions for this PR, I'll loop through the infos and write it in a separate commit so that this workaround will be easy to remove when the support for versions older than astropy 5.3 will be dropped.

@ManonMarchand
ManonMarchand marked this pull request as ready for review July 20, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants