Skip to content

Commit e85fae0

Browse files
committed
Prefix strict-status check names to avoid merge-box name collision
The check run posted by strict_status.yml reused the CI job's exact name (e.g. ubuntu-py313-strict). The PR merge box shows only one check per name, so the neutral strict-status check was hidden behind the CI job's green entry (it still appeared on the Checks tab). Prefix the check name with 'strict-status / ' so it gets its own merge-box row. Claude-Session: https://claude.ai/code/session_01M5FNYqVHbKLbVSGJGftLrL
1 parent 378eeb0 commit e85fae0

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

.github/workflows/strict_status.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
# Turn the outcome of the expected-failures strict array-API jobs into
22
# check runs on the PR. This runs as a separate workflow_run workflow because
33
# pull_request runs for fork PRs get a read-only GITHUB_TOKEN and cannot
4-
# create check runs themselves. Each check uses a stable name (the matrix
5-
# entry name); the outcome is carried by the conclusion and output instead.
4+
# create check runs themselves. Each check uses a stable name ("strict-status
5+
# / " plus the matrix entry name); the outcome is carried by the conclusion
6+
# and output instead.
67
# These checks are informational only (an expected test failure is reported
78
# as neutral, so the PR rollup stays green) and are not intended to be
89
# required checks while the failures are expected.
@@ -126,13 +127,16 @@ jobs:
126127
'complete its tests step. This is an infrastructure error in the ' +
127128
'job itself, not a test failure; see the run log for details.';
128129
}
129-
// Stable check name (just the matrix entry name); the outcome
130-
// lives in the conclusion and output so the checks UI does not
131-
// accumulate differently-named checks per outcome.
130+
// Stable check name; the outcome lives in the conclusion and
131+
// output so the checks UI does not accumulate differently-named
132+
// checks per outcome. The prefix keeps the name distinct from
133+
// the CI job's own check (e.g. "ubuntu-py313-strict") -- the PR
134+
// merge box shows only one check per name, so an identically
135+
// named check run would be hidden behind the CI job entry.
132136
await github.rest.checks.create({
133137
owner: context.repo.owner,
134138
repo: context.repo.repo,
135-
name,
139+
name: `strict-status / ${name}`,
136140
head_sha: run.head_sha,
137141
status: 'completed',
138142
conclusion,

0 commit comments

Comments
 (0)