Charles/targeted banners#1103
Conversation
…o/berkeleytime into charles/sonner-toast-v2
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c60328b6a0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const messages = data?.targetedMessagesForCourse; | ||
| if (!messages?.length) continue; | ||
|
|
||
| syncDismissedTargetedMessages(messages.map((m) => m.id)); |
There was a problem hiding this comment.
Calling syncDismissedTargetedMessages for each individual course wipes dismissed IDs that belong to other displayed courses before they are checked. On pages with multiple selected courses, if the first course has no visible message (or only dismissed ones), a later course’s previously dismissed message can reappear because its ID was removed from localStorage in an earlier iteration. This breaks the expected “dismiss once” behavior for non-persistent messages whenever more than one course is in scope.
Useful? React with 👍 / 👎.
Remove .claude/settings.local.json, revert package.json win32 rollup dep, fix frontend/package.json indentation, revert playwright.config.ts comment change, and remove spurious main.scss trailing newline.
2 participants
removed sonner toast, kept it as targeted banners for targeted classes for grades and enrollment page