Conversation
Hook only runs sanity and api tests, not end to end
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 150f98b9af
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| args: ["--puller=enrollment-timeframe"] | ||
|
|
||
| productionTests: | ||
| suspend: false |
There was a problem hiding this comment.
Setting productionTests.suspend to false in the base app chart enables this CronJob for every deployment that uses infra/app; I checked .github/workflows/cd-stage.yaml and .github/workflows/cd-dev.yaml, and neither overrides productionTests. Since the template hardcodes TEST_ENV=production, each staging/dev deployment will run hourly tests against live berkeleytime.com, creating duplicate production load and noisy failures from non-prod environments.
Useful? React with 👍 / 👎.
| /test-results/ | ||
| /playwright-report/ | ||
| /blob-report/ |
There was a problem hiding this comment.
These patterns are root-anchored, so they do not ignore artifacts produced under apps/tests/ (for example when running tests from that directory as documented). This commit already includes apps/tests/playwright-report/index.html and apps/tests/test-results/.last-run.json, which means routine test runs will keep dirtying git status and make accidental commits of generated artifacts likely.
Useful? React with 👍 / 👎.
3 participants
No description provided.