add college requirements to gradtrak#1140
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95f002dd4b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| export const RCNR_REQ_BTLL = `${RNC_BTLL} | ||
| Function<boolean>(Course) is_upper_div_course (course){ | ||
| string number get_attr(course, "number") | ||
| boolean return or([regex_match(number, "^1[0-9][0-9]"), regex_match(number, "^2[0-9][0-9]"), regex_match(number, "^C[0-9]"), regex_match(number, "^W[0-9][0-9]"), regex_match(number, "^N[0-9][0-9]")]) |
There was a problem hiding this comment.
The RCNR is_upper_div_course predicate currently treats any C followed by one digit as upper division, which incorrectly counts lower-division cross-listed courses (for example C1/C3) toward both the 36-unit and 15-unit upper-division checks. Because regex_match uses String.match semantics, ^C[0-9] is satisfied by those lower-division numbers, so plans can be marked as meeting RCNR upper-division requirements with ineligible coursework.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@garimau This is true, ^C[0-9] should be removed
2 participants
added BtLLs for all remaining colleges that have undergrad majors:
(still need to add graduate college reqs at some point)
also updated UI to show legend for checkmarks next to requirements