add clickable catalog link to course selection cards in grades and en…#1144
add clickable catalog link to course selection cards in grades and en…#1144chwu7 wants to merge 2 commits into
Conversation
…rollment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Linting FailedNote: The status check will always pass. Run Click to expand lint output |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a4ece389f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| year: parsedTerm.year, | ||
| semester: parsedTerm.semester as Semester, | ||
| sessionId: parsedTerm.sessionId, | ||
| classNumber: parsedTerm.classNumber, |
There was a problem hiding this comment.
Preserve semester-wide grade aggregation
When the user selects a semester with All Instructors, this currentInput is sent directly to GetGradeDistributionDocument, and the backend resolver treats year + semester + sessionId + classNumber as getGradeDistributionByClass instead of the semester aggregate. Since the semester option stores a single class number after deduping by year/semester, this changes the displayed grade distribution from all primary sections in that term to one arbitrary section, corrupting semester-only results; keep the catalog link identifier separate from the grade query variables.
Useful? React with 👍 / 👎.
Move classNumber to output metadata (catalogClassNumber) instead of the Input type to prevent it from being passed as a GraphQL variable, which would incorrectly filter grade distributions to a single section. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Linting FailedNote: The status check will always pass. Run Click to expand lint output |
small button to class cards in grades and enrollment to bring you to the catalog version of that class. (year, semester, subject, courseNumber, number, sessionId)