Skip to content

add clickable catalog link to course selection cards in grades and en…#1144

Open
chwu7 wants to merge 2 commits into
mainfrom
charles/clickable-classes
Open

add clickable catalog link to course selection cards in grades and en…#1144
chwu7 wants to merge 2 commits into
mainfrom
charles/clickable-classes

Conversation

@chwu7
Copy link
Copy Markdown

@chwu7 chwu7 commented May 16, 2026

small button to class cards in grades and enrollment to bring you to the catalog version of that class. (year, semester, subject, courseNumber, number, sessionId)

…rollment

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@chwu7 chwu7 requested a review from PineND May 16, 2026 09:04
@github-actions
Copy link
Copy Markdown

Linting Failed

Note: The status check will always pass. Run npm run lint -- --continue to see the full output locally.

Click to expand lint output

> lint
> turbo run lint --continue --output-logs=errors-only


Attention:
Turborepo now collects completely anonymous telemetry regarding usage.
This information is used to shape the Turborepo roadmap and prioritize features.
You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
https://turborepo.com/docs/telemetry

• Packages in scope: @repo/BtLL, @repo/common, @repo/eslint-config, @repo/gql-typedefs, @repo/shared, @repo/sis-api, @repo/storybook, @repo/theme, @repo/typescript-config, ag-frontend, api-sandbox, backend, datapuller, frontend, staff-frontend
• Running lint in 15 packages
• Remote caching disabled
�[;31mbackend:lint�[;0m
cache miss, executing d36054bbf490c50b

> lint
> eslint src/


/home/runner/work/berkeleytime/berkeleytime/apps/backend/src/bootstrap/loaders/apollo.ts
  193:10  error  'getOperationName' is defined but never used  @typescript-eslint/no-unused-vars

✖ 1 problem (1 error, 0 warnings)

npm error Lifecycle script `lint` failed with error:
npm error code 1
npm error path /home/runner/work/berkeleytime/berkeleytime/apps/backend
npm error workspace backend
npm error location /home/runner/work/berkeleytime/berkeleytime/apps/backend
npm error command failed
npm error command sh -c eslint src/
[WARN] command finished with error, but continuing...
::error::backend#lint: command (/home/runner/work/berkeleytime/berkeleytime/apps/backend) /opt/hostedtoolcache/node/22.12.0/x64/bin/npm run lint exited (1)

 Tasks:    6 successful, 7 total
Cached:    0 cached, 7 total
  Time:    11.583s 
Failed:    backend#lint

 ERROR  run failed: command  exited (1)

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5a4ece389f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread apps/frontend/src/app/Grades/index.tsx Outdated
year: parsedTerm.year,
semester: parsedTerm.semester as Semester,
sessionId: parsedTerm.sessionId,
classNumber: parsedTerm.classNumber,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve semester-wide grade aggregation

When the user selects a semester with All Instructors, this currentInput is sent directly to GetGradeDistributionDocument, and the backend resolver treats year + semester + sessionId + classNumber as getGradeDistributionByClass instead of the semester aggregate. Since the semester option stores a single class number after deduping by year/semester, this changes the displayed grade distribution from all primary sections in that term to one arbitrary section, corrupting semester-only results; keep the catalog link identifier separate from the grade query variables.

Useful? React with 👍 / 👎.

Move classNumber to output metadata (catalogClassNumber) instead of
the Input type to prevent it from being passed as a GraphQL variable,
which would incorrectly filter grade distributions to a single section.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Linting Failed

Note: The status check will always pass. Run npm run lint -- --continue to see the full output locally.

Click to expand lint output

> lint
> turbo run lint --continue --output-logs=errors-only


Attention:
Turborepo now collects completely anonymous telemetry regarding usage.
This information is used to shape the Turborepo roadmap and prioritize features.
You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
https://turborepo.com/docs/telemetry

• Packages in scope: @repo/BtLL, @repo/common, @repo/eslint-config, @repo/gql-typedefs, @repo/shared, @repo/sis-api, @repo/storybook, @repo/theme, @repo/typescript-config, ag-frontend, api-sandbox, backend, datapuller, frontend, staff-frontend
• Running lint in 15 packages
• Remote caching disabled
�[;31mbackend:lint�[;0m
cache miss, executing d36054bbf490c50b

> lint
> eslint src/


/home/runner/work/berkeleytime/berkeleytime/apps/backend/src/bootstrap/loaders/apollo.ts
  193:10  error  'getOperationName' is defined but never used  @typescript-eslint/no-unused-vars

✖ 1 problem (1 error, 0 warnings)

npm error Lifecycle script `lint` failed with error:
npm error code 1
npm error path /home/runner/work/berkeleytime/berkeleytime/apps/backend
npm error workspace backend
npm error location /home/runner/work/berkeleytime/berkeleytime/apps/backend
npm error command failed
npm error command sh -c eslint src/
[WARN] command finished with error, but continuing...
::error::backend#lint: command (/home/runner/work/berkeleytime/berkeleytime/apps/backend) /opt/hostedtoolcache/node/22.12.0/x64/bin/npm run lint exited (1)

 Tasks:    6 successful, 7 total
Cached:    0 cached, 7 total
  Time:    12.194s 
Failed:    backend#lint

 ERROR  run failed: command  exited (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant