feat: add "no conflict with schedule" filter to catalog#1145
Merged
Conversation
Adds a new filter option that allows users to select one of their schedules and filter out catalog classes that conflict with non-hidden items in that schedule. - Extract conflict detection utilities to lib/schedule/conflict.ts - Add ScheduleConflictFilter component (only shown when logged in) - Add meetings field to catalog search query for conflict detection - Filter classes client-side based on schedule conflicts Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Linting FailedNote: The status check will always pass. Run Click to expand lint output |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8384c6afd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| page: queryResult.page, | ||
| pageSize: queryResult.pageSize, | ||
| hasNextPage: queryResult.hasNextPage, | ||
| hasNextPage: selectedSchedule ? false : queryResult.hasNextPage, |
There was a problem hiding this comment.
In useCatalogBrowser, setting hasNextPage to false whenever a schedule is selected stops List from calling loadNextPage, so conflict filtering only runs on the first page of catalog results (25 classes) and silently drops all later matches. This makes the "No Conflict With Schedule" results incomplete for any query with more than one page, including the common case where the selected schedule has no meetings (which should return all classes).
Useful? React with 👍 / 👎.
| const selectedSchedule = useMemo(() => { | ||
| if (!filterState.scheduleConflictFilter || !schedules) return null; | ||
| return ( | ||
| schedules.find((s) => s?._id === filterState.scheduleConflictFilter) ?? |
There was a problem hiding this comment.
The selected schedule lookup only matches by _id and ignores year/semester, so after a user switches catalog term, a previously selected schedule from another term can remain active and still filter results. Because ScheduleConflictFilter hides itself when there are no schedules in the new term, this leaves an effectively hidden cross-term filter that users cannot adjust from the control.
Useful? React with 👍 / 👎.
- Keep pagination working when schedule filter is active so all pages can be loaded and filtered (not just first 25 classes) - Validate selected schedule matches current term (year + semester) to prevent hidden cross-term filtering when switching catalog terms Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Linting FailedNote: The status check will always pass. Run Click to expand lint output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new filter option that allows users to select one of their schedules and filter out catalog classes that conflict with non-hidden items in that schedule.