Skip to content

Adding PVs Observability Pods#1147

Merged
MatthewZhu13 merged 7 commits into
mainfrom
resolve-observabilit-PVCs
May 21, 2026
Merged

Adding PVs Observability Pods#1147
MatthewZhu13 merged 7 commits into
mainfrom
resolve-observabilit-PVCs

Conversation

@MatthewZhu13

Copy link
Copy Markdown
Contributor

Each observability pod that needed persistent volume (Grafana, Prometheus, Tempo, Loki) did not have manual PVs setup for their PVCs. Did not error in dev cluster because dev has a StorageManager class setup while prod does not.

Changes:

  • Added manual PVs for Grafana, Prometheus, Tempo, and Loki
  • commented out logging on cache warming since cache warming was depreciated

@MatthewZhu13 MatthewZhu13 requested a review from sashakmurray May 20, 2026 01:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c51942e960

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread infra/observability/templates/prometheus.yaml
Comment thread infra/observability/templates/pv.yaml
sashakmurray
sashakmurray previously approved these changes May 20, 2026

@sashakmurray sashakmurray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go

@asuc-octo asuc-octo deleted a comment from github-actions Bot May 21, 2026
@MatthewZhu13 MatthewZhu13 merged commit 7dbbde4 into main May 21, 2026
5 checks passed
@MatthewZhu13 MatthewZhu13 deleted the resolve-observabilit-PVCs branch May 21, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants