Fix "Open in Grades" in Catalog: pass courseId instead of courseNumber to fix mismatch#1151
Open
ethanransing wants to merge 2 commits into
Open
Fix "Open in Grades" in Catalog: pass courseId instead of courseNumber to fix mismatch#1151ethanransing wants to merge 2 commits into
ethanransing wants to merge 2 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61a1daabed
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Grades deep links carry only courseId, so the parser leaves courseNumber empty. loadOutputsFromInputs now resolves the display number via a new courseById lookup (in parallel with the grade query, non-fatal on failure), fixing blank course numbers and empty edit/filter lookups on Open-in-Grades, refresh, and shared links. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ethanransing
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Another issue: When you open a class in grades and refresh, the name of the course is a blank string:
Root cause:
#1130 changed the backend/frontend contract by adding courseId, but the "Open in Grades" button contract wasn't updated to match this. Instead courseNumber was passed in as courseId, which leads to no match. #1130 also changed the URL writer to not include course number, so on refresh the URL reader can't reconstruct the course number from the course ID in the url.
Fix: