[pull] master from rust-lang:master#124
Merged
Merged
Conversation
Includes various metaModel updates, fixes, and API improvements to make e.g. LspRequestMethod more ergonomic (and use less allocations).
…e_for_update usages
Previously rust-analyzer assumed that a module always had an item list, which isn't true for unresolved modules. Handle this situation gracefully instead of panicking, and add a test. AI disclosure: Written with help by GPT-5.5.
New Rust, new Clippy!
internal: Fix 1.97.0 Clippy
fix: avoid panic in merge imports on trailing path separator
…-clone-for-update Remove redundant clone_for_update
Projection assumes the tuple is big enough for the field access, so return a MIR lowering error earlier if the tuple isn't valid. AI disclosure: Some Fable 5 and GPT 5.5 usage.
When lowering `let (x, y) = not_a_tuple`, we'd panic if `not_a_tuple`
was an alias.
can't project out of Alias(AliasTy { kind: Projection { def_id: TypeAliasId("A") }, .. })
This was because we checked the inferred pattern type from the
`let (x, y)`, concluded it was a tuple, and then tried to project
tuple elements from a non-tuple type (an alias in this case).
Instead, use the place type (`not_a_tuple` in this case) to check that
the expression is actually a tuple we can project out of, and emit a
lowering error otherwise.
AI disclosure: Some Fable 5 and GPT 5.5 usage.
fix: Crash when computing diagnostics with MIR and error types
…ed-module fix: Crash on code actions when an unresolved module is present
Bump gen-lsp-types to v0.10.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )