[pull] master from rust-lang:master#144
Merged
Merged
Conversation
The lack of this has caused an error when it diverges, because `shallow_resolve(ty).is_never()` was false. Given that we should switch to eager normalization anyway, like rustc, this makes sense to do. Also switch the `shallow_resolve(ty).is_never()` to `resolve_vars_with_obligations(ty).is_never()`, because rustc uses this function. And three drive-by changes: - Change referrals to Chalk in logging into next-solver; - In `setup_tracing()`, do not cache the existence of the env var. This function is not perf-sensitive, and caching it means it's more complicated than necessary to change it mid-execution. - Rearrange `expr_guaranteed_to_constitute_read_for_never()` a bit.
fix: Eagerly normalize `.await`'s `IntoFuture::Output`
fix: fix syntax bridge panic when spilting float
fix: Fix `InferenceContext:identity_args` using the wrong DefId
Improve AGENTS.md
fix: Handle enum variants in next-solver `generics`
internal: Pack `ExprOrPatId` when stored, shrink `ScopeData`
internal: Add a more database lifetimes
Record expressions in types in ExprScope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )