[pull] master from rust-lang:master#71
Merged
Merged
Conversation
…ant ID / tuple ID needed) bring back env for projection_ty cleanups
…tOne The old code looks like a copy-paste mistake.
Address the FIXMEs in crates/hir-ty/src/lower.rs where next_ty_var, next_const_var, and next_region_var silently returned error types without emitting diagnostics when inference variables are not allowed (e.g., `_` in type aliases, consts, statics, struct fields). - Add InferVarsNotAllowed variant to TyLoweringDiagnostic enum - Call push_diagnostic in the three next_*_var functions for any non-dummy span - Convert TyLoweringDiagnostic from struct+kind to flat enum with per-variant source (TypeRefId for PathDiagnostic, Span for InferVarsNotAllowed) - Add span_syntax helper resolving all Span variants to AST nodes - Extract expr_syntax/pat_syntax/type_syntax/span_syntax closures from inference_diagnostic into associated functions on AnyDiagnostic - Add InferVarsNotAllowed HIR diagnostic struct with InFile<SyntaxNodePtr> node - Add ide-diagnostics handler with E0121 error code and tests
fix: RunnableKind::Test should map to project_json::RunnableKind::TestOne
`pat()` does not parse or patterns.
feat(diagnostics): emit error for infer vars in non-inference contexts
fix: Parse OR pattern types
internal: Align MIR ProjectionElem more with rustc's version and simplify it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )