[pull] master from rust-lang:master#72
Merged
Merged
Conversation
Example
---
```rust
struct Foo<T, const N: usize>([T; N]);
impl<T, const N: usize> F$0oo<T, N> {
fn spec_len(&self) -> usize {
N
}
}
```
**Before this PR**
```rust
struct Foo<T, const N: usize>([T; N]);
trait SpecLen<T, const N: usize> {
fn spec_len(&self) -> usize;
}
impl<T, const N: usize> SpecLen<T, N> for Foo<T, N> {
fn spec_len(&self) -> usize {
N
}
}
```
**After this PR**
```rust
struct Foo<T, const N: usize>([T; N]);
trait SpecLen {
fn spec_len(&self) -> usize;
}
impl<T, const N: usize> SpecLen for Foo<T, N> {
fn spec_len(&self) -> usize {
N
}
}
```
This is needed so that IDE features can find their anon consts and work with them. We lower them in `field_types()`, which seemed appropriate (we need to know the type for the const, and creating another query doesn't seem worth it). We'll also need them for const eval, but currently default expressions are not handled in MIR.
feat: Lower field defaults to `rustc_type_ir::Const`s
fix: no generate unused generic params in trait sign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )