fix: recursion detection to allow same resolved $ref in different branches

[catosaurusrex2003]

The Problem

The recursion detection algorithm incorrectly throws "too much recursion" errors when the same external $ref appears in multiple branches (e.g. in the schema provided in #1236 c1 and c2 both referencing the same external component).

This happens because the algorithm used a global WeakSet that flagged any object seen before, even if it was in a different branch.

Solution

Replaced global WeakSet tracking with path-based tracking using Set<object>. Each branch now gets its own copy of the path, allowing the same object to appear in different branches while still detecting true circular references.

Key Changes

• Changed WeakSet → Set<object> to enable path copying
• Renamed visited → visitedInPath for clarity
• Create new path copy for each branch instead of sharing global set

Related issue(s)

#1236

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[MichakrawSB]

@magicmatatjahu @fmvilas @AceTheCreator not a big PR, any chance to review and merge it?

[MichakrawSB]

@magicmatatjahu @fmvilas @AceTheCreator any updates?

[YOU54F]

Would also like to see this merged, @catosaurusrex2003 are you able to rebase as there are some conflicts with the base branch.

Are the changes in the playground necessary (tsconfig / package.json) for this change, or were they just for testing purposes?

I would probably advise squashing into a single commit and use conventional commit notation in your message fix: false positive recursion error when same external appears in multiple branches to match the existing convention in the repo

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[AceTheCreator]

Hey @catosaurusrex2003, just a small perf improvement.

I like the idea of creating a new path copy for each branch instead of sharing a global set. What if, during the recursion, we clean up after? currently the clone copies the entire Set at every level. For every tree N levels deep, that's O(N²) work just for tracking.

[catosaurusrex2003]

Nice suggestion
I will look into this and update the pr asap