[BUG] CLI v5 does not accept html-template v3.0.0+

[pioneer2k]

Describe the bug.

We are trying to migrate from CLI v4 to v5. We used the html-template 3.1.0 together with the flag --use-new-generator before, which worked good.
For the migration we simply removed the flag --use-new-generator as suggested because the new generator should be the default.
But the generator gives us the following error:
This template is not compatible with the current version of the generator (3.0.1). This template is compatible with the following version range: >=2.0.0 <3.0.0.

Expected behavior

We expect that all 3.x.x versions of the html-template are working

Screenshots

How to Reproduce

GitHub Actions example:

   - name: ✨ Generating HTML from CheckoutOrders AsyncAPI document
     uses: asyncapi/cli@22eb79671299941961e829b8e4314c98d4b3f14d # v5.0.2
     with:
       template: '@asyncapi/html-template@3.4.0'
       filepath: src/main/resources/asyncapi_checkoutOrders.yml
       parameters: --force-write
       output: asyncapi/checkout-orders-asyncapi-generated-html

🖥️ Device Information [optional]

• Operating System (OS): Ubuntu 22.04
• Browser: -
• Browser Version: -

👀 Have you checked for similar open issues?

• I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines

Are you willing to work on this issue ?

No, someone else can work on it

[Varadraj75]

Hi @pioneer2k @derberg @princerajpoot20 ,

My understanding:
In CLI v5, the new generator is the default, but the compatibility check still seems to enforce <3.0.0, which causes @asyncapi/html-template 3.x.x versions to be rejected even though they should be supported.

My approach to solve this:
I will trace where the generator–template version compatibility is validated in CLI v5, verify why it still expects <3.0.0, and update the logic so all 3.x.x versions of the HTML template work correctly without requiring any legacy flags.

Thanks for reporting this issue. If it’s okay, please assign this to me and I will raise a PR.

[derberg]

@pioneer2k thanks for the issue. Generator and CLI are released, html template not yet

@Varadraj75 if you want to work on the PR please:

• modify https://github.com/asyncapi/html-template/blob/master/package.json#L62 to "generator": ">=2.0.0 <4.0.0",
• https://github.com/asyncapi/html-template/blob/master/README.md should have another paragraph after paragraph: If you use template version v3 with AsyncAPI Generator v2 and it should say If you use template version v3.5 with AsyncAPI Generator v3 and AsyncAPI CLI v5 and put command asyncapi generate fromTemplate <asyncapi.yaml> @asyncapi/html-template@3.5.0

[asyncapi-bot]

🎉 This issue has been resolved in version 3.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[derberg]

@pioneer2k please confirm if all's good

[pioneer2k]

@derberg @Varadraj75
I tried html-template 3.5.0 with cli 5.0.3 now.
Now I get a different error:

◇ Generation failed
Generator Error: require() of ES Module /libraries/node_modules/@asyncapi/generator/node_modules/@exodus/bytes/encoding-lite.js from /libraries/node_modules/@asyncapi/generator/node_modules/isomorphic-dompurify/node_modules/html-encoding-sniffer/lib/html-encoding-sniffer.js not supported.
Instead change the require of encoding-lite.js in /libraries/node_modules/@asyncapi/generator/node_modules/isomorphic-dompurify/node_modules/html-encoding-sniffer/lib/html-encoding-sniffer.js to a dynamic import() which is available in all CommonJS modules.