feat: finish migrating to react renderer#398
Conversation
ibishal
requested review from
asyncapi-bot-eve,
derberg and
fmvilas
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Can you review this PR,
so that i can proceed with this cc @derberg |
|
The cc @derberg |
derberg
left a comment
derberg
left a comment
There was a problem hiding this comment.
good progres
left some suggestions
|
|
done the reviewed changes @derberg |
|
pinging you again cc @derberg |
derberg
left a comment
derberg
left a comment
There was a problem hiding this comment.
nice! did you try to use the template using https://github.com/asyncapi/nodejs-ws-template?tab=readme-ov-file#how-to-use-the-template instruction? I mean the react version?
when running ag command you need to reference local copy of react based template instead of @asyncapi/nodejs-ws-template
ig i have done that, as far as i remember |
|
Lets push this by this weekend, its been pending for a long time cc @derberg |
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
|
cc @derberg |
|
@ibishal let's better focus on moving functionality to generator directly and archiving this repo |
|
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
3 participants
Description
Updated this template to use react renderer
Related issue(s)
#294