Skip to content

chore: get Fran back as maintainer#1104

Merged
asyncapi-bot merged 2 commits into
asyncapi:masterfrom
fmvilas:add-me-as-codeowner
Nov 16, 2025
Merged

chore: get Fran back as maintainer#1104
asyncapi-bot merged 2 commits into
asyncapi:masterfrom
fmvilas:add-me-as-codeowner

Conversation

@fmvilas

@fmvilas fmvilas commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

Description

I'm back...

Related issue(s)
Fixes #1097

@changeset-bot

changeset-bot Bot commented Aug 11, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a87872d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud

Copy link
Copy Markdown

@smoya

smoya commented Aug 11, 2025

Copy link
Copy Markdown
Member

That's brilliant dude! For some reason no PR is able to be merged. Like THIS ONE #1094

More on #1094 (comment)

smoya
smoya previously approved these changes Aug 11, 2025
@fmvilas

fmvilas commented Aug 11, 2025

Copy link
Copy Markdown
Contributor Author

Damn, I haven't landed as a maintainer yet and you're already giving me work to do 😅 Let me check 👀

magicmatatjahu
magicmatatjahu previously approved these changes Aug 11, 2025
@aeworxet

Copy link
Copy Markdown
Contributor

The impossibility to merge PRs is due to the failing Puppeteer test.
I was investigating the issue with @derberg some time ago.

There is no required by Puppeteer software installed by default in GitHub's ubuntu-24.04 runner, and the AppArmor policy has changed since Ubuntu 23.10, so testing of Parser in browser through puppeteer hangs.

All non-merged PRs were going through testing on ubuntu-latest, which is currently ubuntu-24.04.

As a possible solution, this test can be removed from the NPM test script so that it doesn't run as part of the regular tests, and a separate workflow can be created that runs exclusively the Puppeteer test. This workflow can run on just one VM, and it can even be a macOS, as this test is not OS-specific.

jonaslagoni
jonaslagoni previously approved these changes Aug 17, 2025
@sonarqubecloud

Copy link
Copy Markdown

@magicmatatjahu magicmatatjahu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome back! 👋

@derberg

derberg commented Nov 16, 2025

Copy link
Copy Markdown
Member

/rtm

@asyncapi-bot
asyncapi-bot merged commit 772265d into asyncapi:master Nov 16, 2025
11 checks passed
@princerajpoot20

Copy link
Copy Markdown
Member

@fmvilas Welcome back mate! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get back as a maintainer

8 participants