fix: filter out $ref keys in bindings() to prevent undefined parser error

[AayushSaini101]

Fixes #877

Related: #1167

When bindings objects still contain JSON reference keys, treat them as references rather than protocol names so Binding models are not built from invalid data.

[changeset-bot]

🦋 Changeset detected

Latest commit: f53a796

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@asyncapi/parser	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[aeworxet]

@asyncapi/microgrant_team

[princerajpoot20]

I tried the adeo file against this PR branch and still get document: undefined with the same schema-format error.

Can you try it on your end with this file and share the findings: https://github.com/asyncapi/spec/blob/master/examples/adeo-kafka-request-reply-asyncapi.yml

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[AayushSaini101]

Done @princerajpoot20

Tested via this script:

import fs from 'node:fs';
import path from 'node:path';

import { AsyncAPIDocumentV3 } from '../../src/models';
import { Parser } from '../../src/parser';
import { filterLastVersionDiagnostics } from '../utils';

describe('Adeo case study spec', function() {
  const parser = new Parser();
  const specPath = path.join(__dirname, '../mocks/adeo-case-study.yaml');
  const spec = fs.readFileSync(specPath, 'utf8');

  it('should parse the Adeo case study document without registering AvroSchemaParser', async function() {
    const { document, diagnostics } = await parser.parse(spec, { source: specPath });

    expect(document).toBeInstanceOf(AsyncAPIDocumentV3);
    expect(document).toBeDefined();
    expect(filterLastVersionDiagnostics(diagnostics).length === 0).toEqual(true);

    const channel = document!.allChannels().get('costingRequestChannel');
    const responseChannel = document!.allChannels().get('costingResponseChannel');
    const operation = document!.allOperations().get('receiveACostingRequest');

    expect(document!.allServers()).toHaveLength(3);
    expect(document!.allServers().all().map(server => server.id())).toEqual([
      'production',
      'staging',
      'dev',
    ]);

    expect(channel?.address()).toEqual('adeo-{env}-case-study-COSTING-REQUEST-{version}');
    expect(channel?.bindings().get('kafka')?.json()).toEqual({
      replicas: 3,
      partitions: 3,
      topicConfiguration: {
        'cleanup.policy': ['delete'],
        'retention.ms': 60000000,
      },
    });

    expect(responseChannel?.address()).toBeNull();
    expect(responseChannel?.bindings().get('kafka')?.json()?.['x-key.subject.name.strategy']?.type).toEqual('string');

    expect(operation?.summary()).toContain('[COSTING]');
    expect(operation?.bindings().get('kafka')?.json()?.groupId?.type).toEqual('string');

    const requestMessage = document!.allMessages().find(msg => msg.name() === 'CostingRequestV1');
    expect(requestMessage?.title()).toEqual('Costing Request V1');
    expect(requestMessage?.payload()?.schemaFormat()).toEqual('application/vnd.apache.avro;version=1.9.0');
  });
});

[AayushSaini101]

this is the reason it was failing for avro schema parsing, if there is any spec containing avro schema parsing, we need to register manually otherwise it will raise an error cc: @princerajpoot20