fix: add missing '#' to JSON references in 3.0.0 examples (#619)#620
Closed
akannkereuwem1 wants to merge 2 commits into
Closed
fix: add missing '#' to JSON references in 3.0.0 examples (#619)#620akannkereuwem1 wants to merge 2 commits into
akannkereuwem1 wants to merge 2 commits into
Conversation
akannkereuwem1
requested review from
GreenRover,
Pakisan,
asyncapi-bot-eve,
char0n,
dalelane,
derberg,
fmvilas and
jonaslagoni
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
|
Member
|
Already fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In examples/3.0.0/operation.json
, the $ref values for messages are missing the # prefix (e.g., "/components/messages/userSignedUp" instead of "#/components/messages/userSignedUp"). This makes the example document invalid according to JSON Reference standards. This issue was previously reported in #591 but remains open.
Related issue(s)
Fixes #619