Fix AI context selector crash

Fixes #659

Author: mehmetozguldev

src/features/ai/components/mentions/ai-file-selector.tsx

@@ -4,6 +4,7 @@ import {
   useEffect,
   useId,
   useMemo,
+  useRef,
   type KeyboardEvent,
   type ReactNode,
   type RefObject,
@@ -87,6 +88,7 @@ export function AIFileSelector({
   hasLeadingResults = false,
 }: AIFileSelectorProps) {
   const listboxId = useId();
+  const lastEmittedResultsSignatureRef = useRef<string | null>(null);
   const [debouncedQuery] = useDebounce(query, 50);
   const isBackendSearchActive =
     useBackendSearch && debouncedQuery.trim().length > 0 && canUseBackendFileSearch(rootFolderPath);
@@ -114,15 +116,24 @@ export function AIFileSelector({
 
     return flattenFileSearchResults(categorizedFiles);
   }, [backendHits, categorizedFiles, isBackendSearchActive]);
+  const resultFiles = useMemo(() => results.map(({ file }) => file), [results]);
+  const resultFilesSignature = useMemo(
+    () => resultFiles.map((file) => `${file.path}\0${file.name}`).join("\n"),
+    [resultFiles],
+  );
 
   useEffect(() => {
     if (selectedIndex <= results.length - 1) return;
     onSelectedIndexChange?.(Math.max(results.length - 1, 0));
   }, [onSelectedIndexChange, results.length, selectedIndex]);
 
   useEffect(() => {
-    onResultsChange?.(results.map(({ file }) => file));
-  }, [onResultsChange, results]);
+    if (!onResultsChange) return;
+    if (lastEmittedResultsSignatureRef.current === resultFilesSignature) return;
+
+    lastEmittedResultsSignatureRef.current = resultFilesSignature;
+    onResultsChange(resultFiles);
+  }, [onResultsChange, resultFiles, resultFilesSignature]);
 
   useEffect(() => {
     if (!showSearchInput || !autoFocusSearchInput) return;

src/features/ai/components/selectors/context-selector.tsx

@@ -102,16 +102,30 @@ export function ContextSelector({
 
   useEffect(() => {
     if (!isOpen) return;
+    let cancelled = false;
 
-    getAllProjectFiles().then((projectFiles) => {
-      const filtered: FileEntry[] = [];
-      for (const file of projectFiles) {
-        if (!file.isDir && !shouldIgnoreFile(file.path)) {
-          filtered.push(file);
+    getAllProjectFiles()
+      .then((projectFiles) => {
+        if (cancelled) return;
+
+        const filtered: FileEntry[] = [];
+        for (const file of projectFiles) {
+          if (!file.isDir && !shouldIgnoreFile(file.path)) {
+            filtered.push(file);
+          }
         }
-      }
-      setFileItems(filtered);
-    });
+
+        setFileItems(filtered);
+      })
+      .catch((error) => {
+        if (cancelled) return;
+        console.error("Failed to load context files:", error);
+        setFileItems([]);
+      });
+
+    return () => {
+      cancelled = true;
+    };
   }, [isOpen, getAllProjectFiles]);
 
   const bufferByPath = useMemo(

src/ui/command.tsx

@@ -13,6 +13,7 @@ interface CommandProps {
   className?: string;
   onClose?: () => void;
   placement?: "top" | "bottom";
+  title?: string;
 }
 
 const commandContentVariants = cva(
@@ -34,7 +35,14 @@ const commandItemVariants = cva(
   },
 );
 
-const Command = ({ isVisible, children, className, onClose, placement = "top" }: CommandProps) => {
+const Command = ({
+  isVisible,
+  children,
+  className,
+  onClose,
+  placement = "top",
+  title = "Command palette",
+}: CommandProps) => {
   const containerClassName =
     placement === "bottom"
       ? "fixed inset-0 z-[10060] flex items-end justify-center px-4 pb-12"
@@ -59,14 +67,15 @@ const Command = ({ isVisible, children, className, onClose, placement = "top" }:
                   tabIndex={-1}
                 />
               </DialogPrimitive.Overlay>
-              <DialogPrimitive.Content asChild aria-label="Command palette">
+              <DialogPrimitive.Content asChild aria-describedby={undefined}>
                 <motion.div
                   initial={{ opacity: 0, scale: 0.95, y: motionY }}
                   animate={{ opacity: 1, scale: 1, y: 0 }}
                   exit={{ opacity: 0, scale: 0.95, y: motionY }}
                   transition={{ duration: 0.15, ease: "easeOut" }}
                   className={cn(commandContentVariants(), className)}
                 >
+                  <DialogPrimitive.Title className="sr-only">{title}</DialogPrimitive.Title>
                   {children}
                 </motion.div>
               </DialogPrimitive.Content>